Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Disable transaction ban for dev #9921

Closed
xlc opened this issue Oct 3, 2021 · 2 comments · Fixed by #11786
Closed

Disable transaction ban for dev #9921

xlc opened this issue Oct 3, 2021 · 2 comments · Fixed by #11786
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue.

Comments

@xlc
Copy link
Contributor

xlc commented Oct 3, 2021

Currently bad transactions (e.g. when sender account does not have any balance to pay for fees) will get banned for 5 mins. This is necessary for production network but getting annoying for development network.

Should have a CLI flag to disable it or just disable it for dev mode by default.

@bkchr bkchr added the I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. label Oct 3, 2021
@shunjizhan
Copy link

shunjizhan commented Jul 5, 2022

it's potentially useful to disable banning pools completely for dev. Not only bad transactions, but also recently mined tx gets blocked. This behavior blocks implementation of any state revert for dev.

For example, this common testing flow will fail

### setup
- deployLendingContract()
- addLiquidity()
- snapshot()

### senario 1
- revertState()
- tx1: deposit(10 dot)
- tx2: borrow(3 ksm)

### senario 2
- revertState()          // can only revert storage but not the banned mempool
- tx3: deposit(10 dot)   // error: tx temporarily banned (since it's the same as tx1)
- tx4: borrow(5 usdc)

### senario 3
...

@shunjizhan
Copy link

shunjizhan commented Jul 5, 2022

we also got many questions from devs why they got tx temporarily banned error. Such mechanism obviously provides not much merit for dev, but only introduces confusion. So it should only be enabled for prod, if the the chain runs locally with --dev, it can be disabled.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants