Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Document and Calculate Weights for Pallets #5596

Closed
apopiak opened this issue Apr 9, 2020 · 5 comments
Closed

Document and Calculate Weights for Pallets #5596

apopiak opened this issue Apr 9, 2020 · 5 comments
Labels
J1-meta A specific issue for grouping tasks or bugs of a specific category.
Milestone

Comments

@apopiak
Copy link
Contributor

apopiak commented Apr 9, 2020

Issue to track progress on documenting weight for dispatch calls.

In order of benchmarking importance from Gav:

docs weights PR owner pallet
[x] [x] #5680 @apopiak Identity
[x] [x] #5446 @shawntabrizi Balances
[x] [x] #5593 #5775 @shawntabrizi Timestamp
[x] [x] paritytech/polkadot#1036 @shawntabrizi Polkadot/Claims
[x] [x] #5708 @shawntabrizi Vesting
[x] [x] #5771 @thiolliere Im Online
[x] [x] #5964 @shawntabrizi Staking
[x] [x] #5738 @thiolliere Session
[x] [x] #5845 @kianenigma Elections Phragmen
[x] [x] #5828 @thiolliere Democracy
[x] [x] #5802 @apopiak Collective
[ ] [x] #5888 #5851 @tomusdrw @shawntabrizi Offences
[ ] [x] #5723 @thiolliere Treasury
[ ] [x] #5787 @shawntabrizi Utility
[x] low-prio #5593 @apopiak Assets
[x] [x] #5593 #5888 @shawntabrizi System
@apopiak apopiak added the J1-meta A specific issue for grouping tasks or bugs of a specific category. label Apr 9, 2020
@apopiak apopiak added this to the 2.0 milestone Apr 9, 2020
@gui1117
Copy link
Contributor

gui1117 commented Apr 17, 2020

Should we extend this issue with information about:

Create sufficiently accurate weight formula, based solely on call data (not on state!), refactoring dispatches as necessary.
Implement weights through all pallets (FunctionOf).

for #4961

so each pallet should be: benchmarked, documented and have correct weight.

@kianenigma
Copy link
Contributor

I'll grab one or two that I can manage.

@apopiak apopiak changed the title Document Weights for Pallets Document and Calculate Weights for Pallets Apr 21, 2020
This was referenced Apr 24, 2020
@apopiak
Copy link
Contributor Author

apopiak commented Apr 27, 2020

I'm noted down as owner for system, but likely won't be able to get to it in time. So please grab it.

@gui1117
Copy link
Contributor

gui1117 commented Apr 28, 2020

I take democracy but pallet is huge so if someone want to join I push my draft and we can divide extrinsics.

@gui1117
Copy link
Contributor

gui1117 commented May 29, 2020

Did we forget society in our benchmark/weight formula effort ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J1-meta A specific issue for grouping tasks or bugs of a specific category.
Projects
None yet
Development

No branches or pull requests

4 participants