Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Allow for a dynamic number of nominators #12968

Closed
gpestana opened this issue Dec 19, 2022 · 0 comments · Fixed by #12970
Closed

Allow for a dynamic number of nominators #12968

gpestana opened this issue Dec 19, 2022 · 0 comments · Fixed by #12970
Assignees
@gpestana
Labels
J0-enhancement An additional feature request. Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.

Comments

@gpestana
Copy link
Contributor

Task: Replace the maximum allowed number of nominations per nominator with a dynamic maximum based on the account's state (e.g. balance) by defining a typ NominationsQuota that returns the max number of nominations allowed for a given account.

Both the number of targets and nominators (and respective nominations) impacts the size of the snapshot, thus the size of the snapshot may become critically large if the number of votes per nominator are large. Thus, the number of voters that are taken for the election snapshot must be dynamic over the number of nominators and respective nominations.

Related to and reviving this PR and discussion #10340
@gpestana gpestana added the A3-in_progress Pull request is in progress. No review needed at this stage. label Dec 19, 2022
@gpestana gpestana self-assigned this Dec 19, 2022
@gpestana gpestana moved this to 📕 Backlog in (Nominated) Proof of Stake Dec 19, 2022
@gpestana gpestana moved this from 📕 Backlog to ✂️ In progress. in (Nominated) Proof of Stake Dec 19, 2022
@gpestana gpestana mentioned this issue Dec 19, 2022
Merged
@kianenigma kianenigma added J0-enhancement An additional feature request. Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Jan 30, 2023
@github-project-automation github-project-automation bot moved this from ✂️ In progress. to ✅ Done in (Nominated) Proof of Stake Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gpestana gpestana

Labels
J0-enhancement An additional feature request. Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
Projects
(Nominated) Proof of Stake
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[NPoS] Implements dynamic number of nominators paritytech/substrate
2 participants
@gpestana @kianenigma