Fix state_getKeys and state_getKeysPaged almost always erroneously returning an empty result
#2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y returning an empty result
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
melekes
approved these changes
Jul 11, 2022
twiggy diff reportDifference in .wasm size before and after this pull request. |
This was referenced Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nextvariable, which contains the list of queries to perform at the next iteration, can be empty either because we're done or because no progress could be made.Since we iterate forever until progress can be made, there's always a point where no progress can be made anymore.
Unfortunately, we were checking
next.is_empty()too early and assuming that it means that we're done.This PR fixes the logic to check if any progress has been made before assuming success.