-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BestBlockChanged notif in sync and runtime services #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.
twiggy diff reportDifference in .wasm size before and after this pull request.
|
melekes
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a hole in the notifications sent by the syncing service and runtime service.
The problem is as follows:
Normally, we should report P1 as the new best parachain block.
However, it is at the moment not possible to do so. The only way to report a change in the best chain is either when a new block arrives or when a block gets finalized.
This PR therefore introduces a new event
BestBlockUpdated
, which gets generated specifically in this kind of situation.In addition to the parachain syncing code, introducing this new event required modifications to several other parts of the code: the JSON-RPC service, the transactions service, the runtime service, and the asynchronous tree.
I took the liberty to rename the
non_finalized_headers
variable in the JSON-RPC service toheaders
, as this variable also contains the current finalized block (which is an important detail) and this name is therefore misleading.I'm aware of the fact that the
async_tree
is starting to be a bit chaotic, but improving it is a big effort that is out of scope of this PR.