Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GrandPa warp sync robustness to empty responses #722

Open
tomaka opened this issue Apr 6, 2021 · 1 comment
Open

GrandPa warp sync robustness to empty responses #722

tomaka opened this issue Apr 6, 2021 · 1 comment

Comments

@tomaka
Copy link
Contributor

tomaka commented Apr 6, 2021

It is possible right now for a node to send a response that looks like { fragments: Vec::new(), is_finished: false }.
Smoldot will process it, then ask for the rest of the proof.
A node can therefore indefinitely delay the warp syncing by continuously sending empty proofs.
@tomaka tomaka mentioned this issue Jan 26, 2022
Merged
@tomaka
Copy link
Contributor Author

tomaka commented Jan 26, 2022 •
edited
Loading

Seems to have been fixed a while ago in #820, but needs a test.

@tomaka tomaka mentioned this issue Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomaka