Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle warp syncing failures #2529

Open
tomaka opened this issue Jul 19, 2022 · 1 comment
Open

Properly handle warp syncing failures #2529

tomaka opened this issue Jul 19, 2022 · 1 comment

Comments

@tomaka
Copy link
Contributor

tomaka commented Jul 19, 2022

The warp syncing process can fail for various reasons, and currently we just try again. This is a poor idea because all these reasons are "deterministic", in the sense that trying again will always lead to the same error.

What to do in that situation isn't obvious, but I think that the least we can do is print a proper error and stop trying.

@tomaka
Copy link
Contributor Author

tomaka commented Oct 25, 2022

all these reasons are "deterministic", in the sense that trying again will always lead to the same error.

This isn't actually totally true.
For example, the runtime missing the function that we want to call is a pretty terrific/irrecoverable problem, but it could also be caused by a mistake in the runtime, and it could be that in the future this mistake gets corrected on the chain.
In other words, continuing to sync could in principle lead to a recovery.

I think that the behavior of trying again is correct, but we should probably add a delay (in number of blocks) between the syncing attempts.
Additionally, we should probably indicate through logs if this happens (cc #2222).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant