Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make users inject some kind of connectivity object into the JS API #2489

Closed
tomaka opened this issue Jul 9, 2022 · 1 comment
Closed

Make users inject some kind of connectivity object into the JS API #2489

tomaka opened this issue Jul 9, 2022 · 1 comment

Comments

@tomaka
Copy link
Contributor

tomaka commented Jul 9, 2022

Instead of handling the WebSocket and TCP connections internally in the JS library, we should make users inject an object that allows smoldot to reach the other nodes.

Not handling this internally is necessary for Deno compatibility, and it would also clean up the code quite a bit.
@tomaka tomaka mentioned this issue Jul 9, 2022
Closed
@tomaka
Copy link
Contributor Author

tomaka commented Jul 18, 2022

Closing after #2519
I think that #2519 is a better approach than what this issue initially wanted to do.

@tomaka tomaka closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomaka