Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport protocol name changes and forkId #1955

Open
tomaka opened this issue Jan 26, 2022 · 5 comments · May be fixed by #2116
Open

Backport protocol name changes and forkId #1955

tomaka opened this issue Jan 26, 2022 · 5 comments · May be fixed by #2116
Assignees
@melekes

Comments

@tomaka
Copy link
Contributor

tomaka commented Jan 26, 2022

paritytech/substrate#10463
This was referenced Jan 26, 2022
Closed
Merged
@melekes
Copy link
Contributor

melekes commented Mar 2, 2022

Another smoldot PR later should add support for forkId once Substrate/Polkadot have released a version that uses it.

Does the monthly substrate releases count? I can see that the last "stable" release was in Feb. 2021.

If the answer is yes, can I give this a shot?

@tomaka
Copy link
Contributor Author

tomaka commented Mar 2, 2022

Yes, go for it!

I don't think we need to maintain backwards compatibility in smoldot, you can just overwrite /paritytech/grandpa with the replacement name.

You should be able to test if it works by running the JS demo and checking if the finalized block updates itself over time.

@tomaka
Copy link
Contributor Author

tomaka commented Mar 3, 2022 •
edited
Loading

cc paritytech/substrate#10969
(I've coincidentally just noticed that when debugging some parachains stuff)

@melekes melekes self-assigned this Mar 3, 2022
melekes added a commit that referenced this issue Mar 3, 2022
@melekes
change grandpa name to /{genesis_hash}/{fork_id}/grandpa/1
32cdcac 
previous value: `/paritytech/grandpa/1`
also use fork_id, which was added in #1956

Refs #1955
melekes added a commit that referenced this issue Mar 3, 2022
@melekes
add fork_id to ChainKey
c0e841c 
Refs #1955
@melekes melekes linked a pull request Mar 3, 2022 that will close this issue
Open
@tomaka
Copy link
Contributor Author

tomaka commented Aug 12, 2022

paritytech/substrate#11938 also now changed other protocol names.

(see also paritytech/polkadot#5849, but it only changes protocols not implemented in smoldot at the moment)

@tomaka tomaka changed the title Backport Grandpa name change and forkId Backport protocol name changes and forkId Aug 12, 2022
@tomaka
Copy link
Contributor Author

tomaka commented Oct 25, 2022

paritytech/substrate#12545

@tomaka tomaka mentioned this issue Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melekes melekes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change grandpa name and use fork_id paritytech/smoldot
2 participants
@melekes @tomaka