Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Inner hashing of value in state trie (runtime versioning)" #1967

Open
tomaka opened this issue Jan 31, 2022 · 4 comments
Open

Backport "Inner hashing of value in state trie (runtime versioning)" #1967

tomaka opened this issue Jan 31, 2022 · 4 comments

Comments

@tomaka
Copy link
Contributor

tomaka commented Jan 31, 2022

paritytech/substrate#9732

@tomaka
Copy link
Contributor Author

tomaka commented Jan 31, 2022

After #1970 and #1971, what remains is the implementation of the actual changes in the trie. And that's going to be complicated, especially without any specification.

@tomaka
Copy link
Contributor Author

tomaka commented Apr 26, 2022

Some note for myself:

In the Substrate client, ext_storage_root_version_2 always passes as parameter the same value as in RuntimeSpec::state_version. It is RuntimeSpec::state_version that is authoritative as to which version to use for the storage writes. In smoldot I'm going to panic if ext_storage_root_version_2 gets passed a different value.

@tomaka
Copy link
Contributor Author

tomaka commented Apr 26, 2022

The most pressing change to make at the moment is implementing the V1 trie format so that we can generate the proper genesis hash root even if state_version is equal to 1, which is important for the light client to be able to connect to some chains.
Implementing ext_storage_root_version_2 and all is more than secondary.

@tomaka
Copy link
Contributor Author

tomaka commented May 4, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant