Handling the RFC command failed

[skunert]

I tried to merge an RFC, however the command failed.
polkadot-fellows/RFCs#43 (comment)

Block hash 0x6386c7812bbed74cde165d0a074e69fa1b5d6845bf8aa914276305baf6f3b240 looks correct to me however and contains the confirmed event: https://collectives.statescan.io/#/blocks/0x6386c7812bbed74cde165d0a074e69fa1b5d6845bf8aa914276305baf6f3b240

[rzadp]

Hey @skunert,

It looks like the referendum passed, but failed to execute upon enactment:

That's why the command fails to process the PR.

As to why the referendum didn't execute, I don't know, have to look into it.

[skunert]

I think this was some runtime bug at that time. All referenda at that time showed this failure.

The logs of the action that is linked in the issue indicate that it could not fetch the header for whatever reason.

[ggwpez]

The execution does not matter. What matters is whether or not it confirmed - which it did.
The README here reads "block hash of when the referendum was confirmed" so it should still work.
(We can also merge manually, but its probably better to use this case for debugging)

[rzadp]

You're right. I re-run it, and it worked this time - must have been some temporary issue with an RPC node.

As for the failed execution, I was looking into it and found a release from around that time: https://github.com/polkadot-fellows/runtimes/releases/tag/v1.0.0

That release contains this PR, which changes the order of the Collectives Fellowship Origins.

The link to create a referendum generated by the bot should point to Fellows origin. The link in your PR points to Fellowship2Dan.

Fellows used to be second in the order before that PR, and now Fellowship2Dan is second in the order after that PR.
So the mismatch is maybe coming from this change. And the execution fails on bad origin.

[rzadp]

I've run /rfc propose again and the bot generates a proper Fellows origin.

[rzadp]

@skunert Is it possible that you first generated the link which encoded the "second origin", then the release happened, and then you used the link to generate the referendum?

[skunert]

Possible, there was some time between the link generation and me opening the referendum.