[ws transport]: soketto occasionally returns UnexpectedOpCode(Continue) when reading empty WebSocket message

[niklasad1]

I have noticed a difference between soketto v0.3 and soketto v0.4 where it sometimes reads an empty WebSocket message and returns UnexpectedOpCode(Continue).

For the client it doesn't make much difference than just that ERROR jsonrpsee::client::ws::client] Client Error: Inner(Ws(UnexpectedOpCode(Continue))) would be logged, still quite annoying.

For the server, it's critical because it would terminate the connection but I haven't seen it yet at least.... it might just soketto::Client related but receive_data and send_data seems to have the same implemetation.

Note: I tried to downgrade soketto v0.3.2 but it didn't manage to get the ws client/server to work.

[niklasad1]

As Toralf described,

The futures in soketto::receive_data is not cancelable and currently, those futures are spawned in a loop from client -> raw client::next_event -> ws transport::next_response. Thus, it's possible that futures are dropped if the from_front futures finishes first and the client_event/soketto::receive_data future gets dropped.

It was fixed in the WebSocket server: #114 and similar fix should be done in the client to verify if that's issue here (most likely)

However, it will require some refactoring to convert the future into a stream because the client is used for other things too and stream::unfold takes ownership of the closure AFAIK.

[niklasad1]

//cc @maciejhirsz could it be related to "bad performance" i.e, spawning unnecessary futures (bloat the executor thread pool)?

[niklasad1]

Fixed by #180