Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The customized server error codes #1001

Closed
boundless-forest opened this issue Feb 2, 2023 · 2 comments · Fixed by #1004
Closed

The customized server error codes #1001

boundless-forest opened this issue Feb 2, 2023 · 2 comments · Fixed by #1004

Comments

@boundless-forest
Copy link
Contributor

boundless-forest commented Feb 2, 2023

According to https://www.jsonrpc.org/specification#parameter_structures:

-32000 to -32099 | Server error | Reserved for implementation-defined server-errors.

/// Oversized response error code.
pub const OVERSIZED_RESPONSE_CODE: i32 = -32702;
/// Server is busy error code.
pub const SERVER_IS_BUSY_CODE: i32 = -32604;

I guess the two errors are customer server errors and the error codes should be one of the -32000 to -32099?

@niklasad1
Copy link
Member

niklasad1 commented Feb 2, 2023

Yupp, you are right.

Not sure, how we argued (application specific vs server specific) about that previously but let's change those within the -32000 to -32099 range.

@boundless-forest
Copy link
Contributor Author

Fine. I would like to raise a pull request to adjust it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants