Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit: Remove pluralisation from names like finalizedBlocksHashes and prunedBlocksHashes #11

Closed
jsdw opened this issue May 13, 2022 · 0 comments · Fixed by #18
Closed

Comments

@jsdw
Copy link
Collaborator

jsdw commented May 13, 2022

finalizedBlocksHashes => finalizedBlockHashes
prunedBlocksHashes => prunedBlockHashes

I didn't spot whether there were other names with a similar pattern, but basically I'd recommend removing the middle "s" (assuming that we are talking about a list of hashes, one per block, and not a list of hashes where each represents multiple blocks (in which case blocksHashes feels ok to me))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant