From 167c32c824ab62d6d9dab24ea4b9093811c6c37f Mon Sep 17 00:00:00 2001 From: Alexandru Vasile Date: Wed, 14 Feb 2024 10:13:48 +0200 Subject: [PATCH] chainHead/unpin: Return error on duplicate hashes Signed-off-by: Alexandru Vasile --- src/api/chainHead_unstable_unpin.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/api/chainHead_unstable_unpin.md b/src/api/chainHead_unstable_unpin.md index 4c6d528..672b1c8 100644 --- a/src/api/chainHead_unstable_unpin.md +++ b/src/api/chainHead_unstable_unpin.md @@ -3,7 +3,7 @@ **Parameters**: - `followSubscription`: An opaque string that was returned by `chainHead_unstable_follow`. -- `hashOrHashes`: String or array of strings containing the hexadecimal-encoded hash of the header of the block to unpin. +- `hashOrHashes`: String or array of unique strings containing the hexadecimal-encoded hash of the header of the block to unpin. **Return value**: *null* @@ -18,5 +18,6 @@ If this function returns an error, then no block has been unpinned. An JSON-RPC ## Possible errors - A JSON-RPC error with error code `-32801` is generated if the `followSubscription` is valid but at least one of the block hashes passed as parameter doesn't correspond to any block that has been reported by `chainHead_unstable_follow`, or at least one of the block hashes has been unpinned. +- A JSON-RPC error with error code `-32804` is generated if the `hashOrHashes` parameter is an array and at least one of the block hashes is duplicated. - A JSON-RPC error with error code `-32602` is generated if one of the parameters doesn't correspond to the expected type (similarly to a missing parameter or an invalid parameter type). - No error is generated if the `followSubscription` is invalid or stale. The call is simply ignored.