Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@parcel/transformer-babel: remove core-js dep? #4433

Closed
corwin-of-amber opened this issue Apr 5, 2020 · 6 comments
Closed

@parcel/transformer-babel: remove core-js dep? #4433

corwin-of-amber opened this issue Apr 5, 2020 · 6 comments

Comments

@corwin-of-amber
Copy link

🐛 bug report

It seems that this dependency is redundant:

Searching the code base, I only found core-js in the tests.

🔦 Context

core-js is particularly harmful due to zloirock/core-js#548, zloirock/core-js#611, zloirock/core-js#708.

Any chance it can be removed?

@DeMoorJasper
Copy link
Member

@corwin-of-amber there is nothing harmful about asking for some kind of sponsorship for an open source project.

That being said there's the issue of core-js no longer being maintained which will lead to it being replaced at some point...

@corwin-of-amber
Copy link
Author

That is a bit subjective, but in that case the decision is yours.

At any rate, I did not find that @parcel/transformer-babel is even utilizing core-js at all. Am I wrong?

@mischnic
Copy link
Member

mischnic commented Apr 5, 2020

It's used by @babel/preset-env: https://babeljs.io/docs/en/next/babel-preset-env.html#corejs

@mischnic mischnic added the Babel label Apr 5, 2020
@corwin-of-amber
Copy link
Author

Oh, I missed that! Sorry and thanks for the ref @mischnic!

@DeMoorJasper
Copy link
Member

DeMoorJasper commented Apr 5, 2020

Can we close this, as it's not really an issue and a real dependency? The only way around this I see is to enforce all parcel users to install core-js and babel locally besides parcel which would not change anything.

core-js will eventually be replaced as it's no longer maintained but for now I don't see any issue in leaving it as is. I assumed it was abandoned but apparently someone else took over maintaining it

@mischnic mischnic closed this as completed Apr 5, 2020
@mischnic
Copy link
Member

mischnic commented Apr 5, 2020

core-js will eventually be replaced as it's no longer maintained but for now I don't see any issue in leaving it as is.

If it becomes a problem, this is on Babel to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants