-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maxInitCodeSize
txpool test
#924
Comments
I'm interested in taking this one. |
great, there's a function that performs these checks: reth/crates/transaction-pool/src/pool/txpool.rs Lines 777 to 783 in 78ffd0a
|
We need to make sure that the |
good point, this should be part of the |
Do I have to implement to check if initcode size is exceeded? |
we'll likely move this check into the since so this should be pretty straight forward. It should go into the |
Describe the feature
An edge case in geth's txpool implementation was recently found, and fixed in go-ethereum#26504. We should create a test for this case.
The intended behavior of the txpool is to reject transactions where the transaction is a contract creation and the
tx.data
exceedsmaxInitCodeSize
.The
maxInitCodeSize
andmaxCodeSize
, a related constant, are listed in geth here:Additional context
No response
The text was updated successfully, but these errors were encountered: