Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variables values with non-None defaults trample PexInfo settings. #135

Closed
jsirois opened this issue Jul 22, 2015 · 2 comments
Closed

Variables values with non-None defaults trample PexInfo settings. #135

jsirois opened this issue Jul 22, 2015 · 2 comments
Assignees
@jsirois
Labels
bug

Comments

@jsirois
Copy link
Member

jsirois commented Jul 22, 2015

For example, PexInfo's zip_safe is trampled by PEX_FORCE_LOCAL. Any non-None Variables value default currently is treated as-if the env var was actually set by a user:
https://github.com/pantsbuild/pex/blob/master/pex/pex_info.py#L100-L101
@jsirois jsirois added the bug label Jul 22, 2015
@jsirois jsirois self-assigned this Jul 22, 2015
@jsirois jsirois mentioned this issue Jul 23, 2015
Closed
@jsirois
Copy link
Member Author

jsirois commented Jul 23, 2015

This issue was spotted over in pants after the upgrade to pex 1.0.x by @grantbot: https://groups.google.com/d/topic/pants-devel/CuAV8AO0Hbg/discussion

In the pants case, a python_binary marked zip_safe=False correctly generates a pex with a zip_safe=false PEX-INFO manifest, but when the binary is run it acts as if PEX_FORCE_LOCAL has been explicity set to false, thus ignoring the PEX-INFO setting systemically.

@jsirois
Copy link
Member Author

jsirois commented Aug 4, 2015

Fix is in @ 7654a4c

@jsirois jsirois closed this as completed Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsirois