Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure under julia-v1.12.0-DEV #91

Closed
dmbates opened this issue Apr 16, 2024 · 1 comment · Fixed by #92
Closed

Test failure under julia-v1.12.0-DEV #91

dmbates opened this issue Apr 16, 2024 · 1 comment · Fixed by #92

Comments

@dmbates
Copy link
Collaborator

dmbates commented Apr 16, 2024

Under

julia> versioninfo()
Julia Version 1.12.0-DEV.348
Commit d8b9810b890 (2024-04-16 00:07 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: macOS (arm64-apple-darwin22.4.0)
  CPU: 8 × Apple M1 Pro
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, apple-m1)
Threads: 6 default, 0 interactive, 6 GC (on 6 virtual cores)

the "Simple linear regression" test fails.

Test Summary:                 | Pass  Fail  Total   Time
MixedModelsMakie.jl           |   66     1     67  28.9s
  Aqua                        |    7            7   5.9s
  utilities, types and tables |   24     1     25   4.4s
    utilities                 |    5            5   0.0s
    Simple linear regression  |    2     1      3   1.2s
    confint_table             |    4            4   2.7s
    ranefinfo                 |   13           13   0.3s
  [qq]caterpillar             |   10           10   3.8s
  clevelandaxes               |    1            1   0.9s
  coefplot                    |    4            4   0.4s
  recipes                     |    3            3   0.5s
  ridgeplot                   |    2            2   1.5s
  ridge2d                     |    4            4   2.1s
  shrinkageplot               |    9            9   2.4s
  splom!                      |    2            2   0.7s
  profile                     |                 0   6.2s

I assume this is because the data are generated using MersenneTwister(42) and that result may have changed between Julia versions. Should we use StableRNGs instead?

@palday
Copy link
Owner

palday commented Apr 16, 2024

Yes, please. I would also check that there isn't a change in floating point error from a LinearAlgebra tweak -- if there is, then we should adjust our tolerances accordingly as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants