Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump guava to 33.1.0 #509

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

wi11dey
Copy link
Contributor

@wi11dey wi11dey commented Jun 21, 2024

In preparation for adding the debug server

@wi11dey
Copy link
Contributor Author

wi11dey commented Jun 21, 2024

SHA1: 9b7ed39143d59e8eabcc6f91ffe4d23db2efe558
SHA256: 346aec0eb8c8987360c8a264e70ff10c2fba760446eb27e8ab07e78e787a75fe

@d-guo
Copy link
Contributor

d-guo commented Jun 25, 2024

have you checked that there's no breaking changes?

@wi11dey
Copy link
Contributor Author

wi11dey commented Jun 25, 2024

yup, these are the changes: https://github.com/google/guava/releases

combined changelog:

  • Changed Gradle Metadata to include dependency versions directly. This may address missing guava dependencies when updating from 32.0.1-jre to 32.1.1-jre google/guava#6657 that some users have reported (which might be a result of users' excluding guava-parent). (google/guava@c6d35cf)
  • collect: Changed Multisets.unmodifiableMultiset(set).removeIf(predicate) to throw an exception always, even if nothing matches predicate. (google/guava@61dbccf)
  • graph: Fixed the behavior of Graph/ValueGraph views for a node when that node is removed from the graph. (google/guava@9507996)
  • io: Fixed Files.createTempDir and FileBackedOutputStream under From Guava 32.0.1-jre, Files.createTempDir() and FileBackedOutputStream can fail or create un-deletable directories/files when used from a Windows service google/guava#6634. (The fix actually covers only Java 9+ because Java 8 would require an additional approach. Let us know if you need support under Java 8.) (google/guava@f87f68c)
  • net: Made MediaType.parse allow and skip over whitespace around the / and = separator tokens in addition to the ; separator, for which it was already being allowed. (google/guava@2786f83)
  • util.concurrent: Tweaked Futures.getChecked constructor-selection behavior: The method continues to prefer to call constructors with a String parameter, but now it breaks ties based on whether the constructor has a Throwable parameter. Beyond that, the choice of constructor remains undefined. (For this and other reasons, we discourage the use of getChecked.) (google/guava@59cfb22)
  • This version of guava-android contains some package-private methods whose signature includes the Java 8 Collector API. This is a test to identify any problems before we expose those methods publicly to users. Please report any problems that you encounter. (google/guava@73dbf7e)
  • Changed various classes to catch Exception instead of RuntimeException even when only RuntimeException is theoretically possible. This can help code that throws undeclared exceptions, as some bytecode rewriters (e.g., Robolectric) and languages (e.g., Kotlin) do. (google/guava@c294c23, google/guava@747924e, google/guava@b2baf48)
  • Added an Automatic-Module-Name to failureaccess, Guava's one strong runtime dependency. (google/guava@280b5d2)
  • reflect: In guava-android only, removed Invokable.getAnnotatedReturnType() and Parameter.getAnnotatedType(). These methods never worked in an Android VM, and to reflect that, they were born @deprecated, @beta, and @DonotCall. They're now preventing us from rolling out some new Android compatibility testing. This is the only binary-incompatible change in this release, and it should have no effect in practice. Still, we bump the major version number to follow Semantic Versioning. (google/guava@045cd84)
  • util.concurrent: Changed our implementations to avoid eagerly initializing loggers during class loading. This can help performance, especially under Android. (google/guava@4fe1df5)
  • Updated our Error Prone dependency to 2.26.1, which includes a JPMS-ready jar of annotations. If you use the Error Prone annotations in a modular build of your own code, you may need to add a requires line for them. (google/guava@d48c6df, google/guava@c6e91c4)
  • base: Added a Duration overload for Suppliers.memoizeWithExpiration. (google/guava@76e46ec)
  • base: Deprecated the remaining two overloads of Throwables.propagateIfPossible. They won't be deleted, but we recommend migrating off them. (google/guava@cf86414)
  • cache: Fixed a bug that could cause refactor: make LocalCache not use synchronized to detect recursive loads (#6845) google/guava#6851 (comment). (google/guava@0e1aebf)
  • graph: Changed the return types of transitiveClosure() and reachableNodes() to Immutable* types. reachableNodes() already returned an immutable object (even though that was not reflected in the declared return type); transitiveClosure() used to return a mutable object. The old signatures remain available, so this change does not break binary compatibility. (google/guava@09e655f)
  • graph: Changed the behavior of views returned by graph accessor methods that take a graph element as input: They now throw IllegalStateException when that element is removed from the graph. (google/guava@8dca776)
  • hash: Optimized Checksum-based hash functions for Java 9+. (google/guava@afb35a5)
  • testing: Exposed FakeTicker Duration methods to Android users. (google/guava@f346bbb)
  • util.concurrent: Deprecated the constructors of UncheckedExecutionException and ExecutionError that don't accept a cause. We won't remove these constructors, but we recommend migrating off them, as users of those classes often assume that instances will contain a cause. (google/guava@1bb3c43)
  • util.concurrent: Improved the correctness of racy accesses for J2ObjC users. (google/guava@d3232b7)

also ensured Cassandra starts up fine after the bump; the rolling-JFR cluster on the dev stack currently has 33.1.0 on its classpath due to version constraint solving with the debug server

@d-guo
Copy link
Contributor

d-guo commented Jun 25, 2024

nice, taking a quick glance over the changes here, i think they're all fine

@wi11dey wi11dey merged commit 63ea150 into palantir-cassandra-2.2.18 Jun 25, 2024
5 checks passed
shamith09 pushed a commit that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants