Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v6.1.0 #373

Closed
legobeat opened this issue May 12, 2023 · 9 comments · Fixed by #378
Closed

Release v6.1.0 #373

legobeat opened this issue May 12, 2023 · 9 comments · Fixed by #378
Milestone

Comments

@legobeat
Copy link
Contributor

legobeat commented May 12, 2023

Some great improvements have been merged to master since the release of v6.0.0 that I think will make users delighted.

https://github.com/pahen/madge/milestone/4

@legobeat
Copy link
Contributor Author

@kamiazya @PabloLION What are your thoughts here?

@kamiazya
Copy link
Collaborator

@legobeat Thank you so much for your patience.

I must apologize for the delayed response as my attention has been divided between work and personal commitments lately.

The milestone mentioned does not offer a comprehensive review of the changes made, rather it is a tool I use to keep track of the contributions I've merged and the queries I've responded to.

That being said, it's absolutely worth enriching the software with new features. Therefore, let's progress towards the new release.

If there are any particular areas that you believe need addressing prior to the release of version 6.1.0, kindly bring them to my attention. Your input is invaluable.

@legobeat
Copy link
Contributor Author

legobeat commented May 18, 2023

@kamiazya Thank you for following up. From my perspective as a user and without looking closer yet, master should be releasable as-is? Anything outstanding can be addressed in a future version IMO (theoretical breakages aside obv).

Happy do prerelease testing or review if that's helpful. Perhaps we can keep this issue to post links to anything that does come up running up to the release?

@legobeat
Copy link
Contributor Author

Looking at the diff, the one suggestion I'd make for next release would be #376 .

@kamiazya
Copy link
Collaborator

kamiazya commented Jun 1, 2023

@legobeat
#376 merged.

If there is anything else that should be addressed, please comment.

I will have time to work on the release this weekend.

@legobeat
Copy link
Contributor Author

legobeat commented Jun 2, 2023

Thank you! I am not aware of anything else and master looks good from here. But will try take another look shortly. Feel free to @ me if anything unexpected comes up as you do and assistance with testing/review/etc of anything particular is required :)

@kamiazya kamiazya added this to the [Planning]6.1.0 milestone Jun 4, 2023
@kamiazya kamiazya mentioned this issue Jun 4, 2023
@kamiazya
Copy link
Collaborator

kamiazya commented Jun 4, 2023

The release is complete, but there are issues with the integrity of the master branch.

#378

This issue will be closed after the above is completed.

@binjospookie
Copy link

Madge 6.1.0

node:internal/modules/cjs/loader:933
  const err = new Error(message);
              ^

Error: Cannot find module 'walkdir'
Require stack:
- /Users/binjo/Documents/work/grlt/toolchain/design-review/node_modules/madge/lib/tree.js
- /Users/binjo/Documents/work/grlt/toolchain/design-review/node_modules/madge/lib/api.js

@legobeat
Copy link
Contributor Author

legobeat commented Jun 8, 2023

@binjospookie Can you give instructions on how to reproduce your issue? Nothing should have changed around walkdir recently and it should be available as a module: https://github.com/pahen/madge/blame/master/package.json#L68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants