Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can I Deploy toMainBranch Checks All Versions on Main Branch #1758

Closed
ealesjordan opened this issue Jan 9, 2024 · 0 comments · Fixed by #1759
Closed

Can I Deploy toMainBranch Checks All Versions on Main Branch #1758

ealesjordan opened this issue Jan 9, 2024 · 0 comments · Fixed by #1759

Comments

@ealesjordan
Copy link
Contributor

Related to: #1742

When I added this change I didn't add a latest flag on the matrix call so when running the can i deploy check it wouldn't just check the latest main branch version but would check a load of old ones. This would return some unverified pacts if the branch has only been compared to the latest main.

I have a PR to solve this but wanted to outline the issue here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 1758 - Add latest flag when comparing to the main branch ealesjordan/pact-jvm
1 participant
@ealesjordan