Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling of body responses with content-type application/x-thrift #1298

Closed
ewebprojects opened this issue Jan 28, 2021 · 3 comments
Closed

Comments

@ewebprojects
Copy link

hello - is it possible to have body responses with content-type 'application/x-thrift' handled in the same way as body responses with content-type 'application/x-thrift+json' ?

For legacy/corporate reasons we are unable to modify the content type produced by our application, so we are stuck with 'application/x-thrift' which to the best of my understanding means body responses will be compared using string equality, and matchers wont be taken into account.

The alternative would be to fork the pact-jvm code and make that change in the forked pact-jvm code base, but maybe there's another easier way.

thanks

@uglyog
Copy link
Member

uglyog commented Jan 28, 2021

You could fork the pact-jvm code and make that change, and then submit a PR for the fix :-D

@iankurrathi
Copy link
Contributor

iankurrathi commented Feb 10, 2021

You could fork the pact-jvm code and make that change, and then submit a PR for the fix :-D

Hi @uglyog, PR created for this issue: #1304
Can you please have a look?
Thanks.

@uglyog
Copy link
Member

uglyog commented Feb 11, 2021

4.1.17 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants