-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web] Implement Event "New resource" #9782
Comments
Re-opening here since the implementation has some drawbacks and is therefore not enabled currently. The problem we're facing is that e.g. during uploads, a newly created resource will be fetched by the SSE event. That will result in an absurd number of requests when uploading 1000+ files. A solution could be to make the uploading files accessible from the outside and avoid fetching them via the SSE event. |
Not sure this is something to handle here or somewhere else: metadata might not be available immediately after upload because it relies on the indexing which happens async afaict... any idea how to take this into account? cc @kobergj |
Why does metadata depend on indexing? If you PROPFIND the file you should always get the full metadata independent of the indexing. Afaik indexing only affects search |
No, audio and location metadata is written into the metadata by the search service after the indexing |
Blocked by owncloud/ocis#8677 |
Update because we talked about this again today. After uploading a file, the web will anyway need to fetch resources again as they could (potentially) be changed by the postprocessing. The only way to be sure for web it doesn't have to propfind again is by comparing the etag. For other sse events the |
owncloud/ocis#8701 is merged in ocis. Any blockers for web development? |
No more blockers atm. Will be handled by web this sprint. |
Description
User Stories
Value
Immediate user feedback
Acceptance Criteria
Definition of ready
[ ] everybody needs to understand the value written in the user story
[ ] acceptance criteria has to be defined
[ ] all dependencies of the user story need to be identified
[ ] feature should be seen from an end user perspective
[ ] user story has to be estimated
[ ] story points need to be less then 20
Definition of done
[ ] functionality described in the user story works
[ ] acceptance criteria are fulfilled
[ ] code review happened
[ ] CI is green
[ ] critical code received unit tests by the developer
[ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
[ ] no sonar cloud issues
The text was updated successfully, but these errors were encountered: