Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Implement Event "New resource" #9782

Closed
2 tasks
exalate-issue-sync bot opened this issue Oct 9, 2023 · 8 comments · Fixed by #10026 or #10709
Closed
2 tasks

[web] Implement Event "New resource" #9782

exalate-issue-sync bot opened this issue Oct 9, 2023 · 8 comments · Fixed by #10026 or #10709
Assignees
Labels

Comments

@exalate-issue-sync
Copy link

exalate-issue-sync bot commented Oct 9, 2023

Description

User Stories

  • As a client i want to know in real time when a resource has been created to update my view.

Value

Immediate user feedback

Acceptance Criteria

  • New resources are published via SSE
  • Metadata about the resource needs to be clarified with clients [~jstehle] [~tbaader]

Definition of ready

[ ] everybody needs to understand the value written in the user story
[ ] acceptance criteria has to be defined
[ ] all dependencies of the user story need to be identified
[ ] feature should be seen from an end user perspective
[ ] user story has to be estimated
[ ] story points need to be less then 20

Definition of done

  • Functional requirements
    [ ] functionality described in the user story works
    [ ] acceptance criteria are fulfilled
  • Quality
    [ ] code review happened
    [ ] CI is green
    [ ] critical code received unit tests by the developer
    [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
  • Non-functional requirements
    [ ] no sonar cloud issues
@micbar micbar transferred this issue from owncloud/ocis Oct 9, 2023
@micbar micbar added Priority:p3-medium Normal priority and removed p3-medium labels Oct 9, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Infinite Scale Team Board Nov 22, 2023
@JammingBen JammingBen reopened this Dec 8, 2023
@github-project-automation github-project-automation bot moved this from Done to In progress in Infinite Scale Team Board Dec 8, 2023
@JammingBen
Copy link
Contributor

Re-opening here since the implementation has some drawbacks and is therefore not enabled currently. The problem we're facing is that e.g. during uploads, a newly created resource will be fetched by the SSE event. That will result in an absurd number of requests when uploading 1000+ files.

A solution could be to make the uploading files accessible from the outside and avoid fetching them via the SSE event.

@JammingBen JammingBen moved this from In progress to Qualification in Infinite Scale Team Board Dec 8, 2023
@dschmidt
Copy link
Member

dschmidt commented Dec 8, 2023

Not sure this is something to handle here or somewhere else: metadata might not be available immediately after upload because it relies on the indexing which happens async afaict... any idea how to take this into account?

cc @kobergj

@kobergj
Copy link
Contributor

kobergj commented Dec 8, 2023

Why does metadata depend on indexing? If you PROPFIND the file you should always get the full metadata independent of the indexing. Afaik indexing only affects search

@dschmidt
Copy link
Member

dschmidt commented Dec 8, 2023

No, audio and location metadata is written into the metadata by the search service after the indexing

@JammingBen JammingBen moved this from Qualification to Features / Enhancements in Infinite Scale Team Board Dec 12, 2023
@kulmann kulmann moved this from Features / Enhancements to Backlog in Infinite Scale Team Board Mar 14, 2024
@AlexAndBear
Copy link
Contributor

Blocked by owncloud/ocis#8677
see @JammingBen s commented

@micbar micbar moved this from Backlog to blocked in Infinite Scale Team Board Mar 18, 2024
@kobergj
Copy link
Contributor

kobergj commented Mar 20, 2024

Update because we talked about this again today.

After uploading a file, the web will anyway need to fetch resources again as they could (potentially) be changed by the postprocessing. The only way to be sure for web it doesn't have to propfind again is by comparing the etag.

For other sse events the initiator id logic makes indeed sense and will be implemented with owncloud/ocis#8701

@butonic
Copy link
Member

butonic commented Apr 2, 2024

owncloud/ocis#8701 is merged in ocis. Any blockers for web development?

@kobergj
Copy link
Contributor

kobergj commented Apr 2, 2024

No more blockers atm. Will be handled by web this sprint.

@AlexAndBear AlexAndBear self-assigned this Apr 4, 2024
@AlexAndBear AlexAndBear moved this to In progress in Infinite Scale Team Board Apr 4, 2024
@AlexAndBear AlexAndBear mentioned this issue Apr 5, 2024
8 tasks
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants