show file-locking information

[exalate-issue-sync]

Description

Info about locking is (somehow) available in the backend

User Stories

• As a user I who has write permissions to a file I want to know if a file is locked, so that I know why I can't edit it.

Value

• working on office files

Acceptance Criteria

• If file is locked, 🔒-Icon is shown next to share-indicators in filelist and Details-Right Sidebar Panel
• Icon is shown immeadiately (--> SSE)-> split out to new ticket
• Click on 🔒-Icon in files-list, opens right sidebar "Details" -Panel
• "Lock"Information in the files-details:
  • If Locked Show "Lock: Locked by [Displayname] 23 minutes ago." (if this info is available)
  • If Locked Show "Locked since: Relative Date" (+ Tooltip with Absolute Date)
  • If Locked Show "Locked expires: Relative Date" (+ Tooltip with Absolute Date)
• Automatic unlocking happens after 30 mins per default; can be adjusted via config file.
• If file is locked: not available fileactions (move, rename, delete) are disabled and get the addition "(locked)" see sribble
• Cherry on top: add an indicator on the Filetype icon, so that users see instantly if a file is locked.

Definition of done

• Functional requirements
  [ ] functionality described in the user story works
  [ ] acceptance criteria are fulfilled
• Quality
  [ ] codre review happened
  [ ] CI is green
  [ ] critical code received unit tests by the developer
  [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
• Non-functional requirements
  [ ] no sonar cloud issues

[exalate-issue-sync]

Benedikt Kulmann commented: locking information is available in propfinds via property {DAV:}lockdiscovery. Needs to be added to the default dav properties in the constants of packages/web-pkg.

[tbsbdr]

closed by mistake, reopening

[lookacat]

we can't get the timestamp of the lock since its not implemented in the backend

[exalate-issue-sync]

Florian Schade commented: SSE part follows: owncloud/ocis#6992

[tbsbdr]

As discussed:

• should be accessible
• Add tippy "Item is locked" on hover of the filetype&lock-icon
• single-selection: disable non-available actions (cut, rename, delete)

Note: lets see if the overlayed lock-icon on the file-icon receives positive feedback by the users; if not we might need to move it to the shared/status column. let's try :D

[lookacat]

done, will only add unittests then it can get merged

[ScharfViktor]

that is great, we avoid a lot of errors when user tries to delete or move locked file

one question: maybe also hide buttons create tag and share for locked file? because it fails like deleting or moving locked file.