Links tweaks after review

[pmaier1]

Moved to https://github.com/owncloud/enterprise/blob/master/product/oc10/index.md#links

[felixheidecke]

Design reference: #583 (comment)

[pmaier1]

Feedback

• Date picker for expiration date is missing
• Link URLs are not visible deferred
• Roles should be handled via a picker instead of radio buttons (=> save space / consistency with collaborators) => Role interaction not consistent between collaborators and link share #1907
• Editing a link has the headline "Add a new link" (=> just remove the headline generally?)
• Links redirect to classic frontend
• Round link icon not aligned with "squared" avatars => obsolete
• Glitch: When switching from "Collaborators" tab to "Links" tab and the link list loads, there's some jerk (same if you e.g. switch from a single file to a folder, which has links, in the file list) => obsolete
• Private link missing => it's in the header now already
• You can edit an existing link and create a new one at the same time => looks strange => Confusing layout in collaborators UI #1908
• Expiration date and password fields grab saved credentials
  
• If there's no link yet, show an explanation => obsolete
• "Add link" button is lame => deferred
• Collaborators does not show an "edit" button but lets you edit on click
• "Folder permissions" => "Roles"
• Editing a link without making changes and clicking on "Save" creates an error (=> "Save" could be greyed-out unless you make changes or it should only appear when there are changes to save)
  => possibly obsolete ?
• To be continued

[felixheidecke]

• Roles should be handled via a picker instead of radio buttons (=> save space / consistency with collaborators)

@pmaier1 Here is UX input on using Radio Buttons vs Drop-Down Menus:
https://blog.prototypr.io/7-rules-of-using-radio-buttons-vs-drop-down-menus-fddf50d312d1

Let's always keep UX in mind, when designing. 👍

[LukasHirt]

Links redirect to classic frontend

Needs phoenix.baseUrl in config.php in phoenix demo

[DeepDiver1975]

Needs phoenix.baseUrl in config.php in phoenix demo

taken care of - shall be live later today

[pmaier1]

Are all the points solved/mitigated?

[felixheidecke]

@pmaier1 did you take a look @ this here: #1827 (comment)

I checked off the boxes in the PR.

[LukasHirt]

• Implement tabs in links same as in collaborators: Role interaction not consistent between collaborators and link share #1907

[kulmann]

Further inputs based on feedback from @pmaier1:

• (Somehow) add help texts for private and public links. Maybe as help icon (question mark) with tooltip text, so that they don't take too much space in the UI.
  Explanation text for private links: "Only invited collaborators can use this link."
  Explanation text for public links: "Anyone with the link can access this resource. No sign-in required."
• form label for public link name includes an action in its wording. Should receive a label like title or identifier instead of Name your link.
• The translation for the "Contributor" role ("Mitarbeiter") is bad as Collaborators would also translate to "Mitarbeiter". We should change it. Moved to German wording of contributor role for public links #2934

[kulmann]

Moving here from #2903

• When clicking a public link name, the public link opens in the current tab and you can hardly go back because of the redirect. => Should open in a new tab
• "Expires on" indicator only works for the current year. If you set an expiration date next year, the remaining time is calculated using the date in the current year instead of next year) can't confirm. Date in the next year resolves to "Läuft ab in einem Jahr".
• Usually link properties are displayed as text (role, expiration). Only the password-protection state is displayed using the link icon which is unintuitive.
• The on-click visualization of the "copy to clipboard" button is too less visible. Maybe use checkmark as when copying a private link?

[kulmann]

• Change order of sidebar tabs. Collaborators should come first, Links second.

[kulmann]

• Make public link list entries visually consistent with collaborator list entries, i.e. "x" for removal as first grid column, icons for editing and copying without border (i.e. just icons) as the rightmost grid columns
• Make sure that removing an expiration date from a public link is only possible when the link settings allow it (i.e. if expiration dates are not enforced)

[PVince81]

the PR was merged, @kulmann please tick the checkboxes and close if nothing is left