Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM. [QA] federated user from different instances are indistinguishable when they share the same full name #10734

Open
Tracked by #9735
jnweiger opened this issue Nov 26, 2024 · 3 comments
Labels

Comments

@jnweiger
Copy link
Contributor

jnweiger commented Nov 26, 2024

Followup on owncloud/web#11361

Steps to reproduce

Setup three machines with e.g.

env OCIS_DNSNAME=cat-7rc3-DATE OCIS_VERSION=v7.0.0-rc.3 ./deploy_ocis_bare_metal.sh
env OCIS_DNSNAME=dog-7rc3-DATE OCIS_VERSION=v7.0.0-rc.3 ./deploy_ocis_bare_metal.sh
env OCIS_DNSNAME=elf-7rc3-DATE OCIS_VERSION=v7.0.0-rc.3 ./deploy_ocis_bare_metal.sh

mutually register the machines in their ocmproviders.json; service ocis restart

At machine dog, create user carol and bob. At elf and cat, create a user bob with different mail addresses.
carol invites both external bob's and they accept.
When carol shares a folder, with all three bobs, the search results expose full name and email. OK
But later, we cannot distinguish multiple external users "Bob Builder".
(In this example one Bob is misspelled as Bpb, luckily...)

Specifically:
Shares -> 'Shared with others' should clearly identify the share receivers.
It should include the name of the remote instance in case of federated shares.

Shares -> 'Shared with me' should clearly identify the sharer.
It should include the name of the remote instance in case of federated shares.

image


image


image


image

Expected behavior

The email should be exposed too.
The name of the federated machine should show up in the details.

@hodyroff fyi.

@rhafer
Copy link
Contributor

rhafer commented Nov 27, 2024

I think this is a web issue. We could use the issuer value from the identities property in the graph users response to distinguish federated users coming from different federated servers.

@rhafer rhafer transferred this issue from owncloud/ocis Nov 27, 2024
@JammingBen JammingBen added the Priority:p3-medium Normal priority label Nov 27, 2024
@JammingBen
Copy link
Contributor

I can use the issuer in the search input field, any other places don't have this information though. It seems to be missing in the permissions and the sharedWithMe responses from the server.

@JammingBen
Copy link
Contributor

Issuer has been added to the share input field via owncloud/web#12002. For the rest, see my comment above. Transferring the issue to the ocis repo again because of that.

@JammingBen JammingBen removed their assignment Dec 5, 2024
@JammingBen JammingBen transferred this issue from owncloud/web Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Prio 3 or less
Development

No branches or pull requests

3 participants