Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main menu does not work in safari #11718

Closed
DionTimmermann opened this issue Oct 4, 2024 · 4 comments · Fixed by #11726
Closed

Main menu does not work in safari #11718

DionTimmermann opened this issue Oct 4, 2024 · 4 comments · Fixed by #11726
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@DionTimmermann
Copy link

Describe the bug

Clicking on an item in the main menu (3-by-3 grid at top left) does not open the desired page when using safari.

Likely reason: The menu disappears on mouse down, but the link would only be clicked on mouse up.

Steps to reproduce

  1. Open OCIS in Safari (I am using the admin user created during installation).
  2. Click on the main menu (3-by-3 grid at top left.
  3. The menu opens with 4 icons (Files, Text Editor, App Store, Admin Settings)
  4. Click on any item in the menu.

Expected behavior

The clicked-on page opens and the menu disappears.

Actual behavior

The menu disappears, but the page is not changed.

Setup

I used a fresh install of OCIS 6.5.0 with Web client version 10.3.0. I used sudo -u ocis ocis init --config-path /containers/ocis/config --admin-password "XXXXX" --insecure true to configure the server.
The server runs on a machine in my local network and is behind a nginx reverse proxy with the recommended additional settings:

        # OIDC Tokens in headers are quite large and can exceed default limits of reverse proxies
        proxy_buffers 4 256k;
        proxy_buffer_size 128k;
        proxy_busy_buffers_size 256k;

        # Disable checking of client request body size
        client_max_body_size 0;

Additional context

  • The problem only ocurs with safari [I currently use Version 16.6 (18615.3.12.11.2)]. With chrome everything works as expected.
  • I do not see any errors in the safari developer console, except a failure to load /ocs/v2.php/apps/notifications/api/v1/notifications/sse, which I guess is not related.
  • Open the pages by entering the respective url in the browser's menu bar, works. E.g. going to admin-settings/general loads the "Admin Settings". The menu also does not work on these pages.

In safari, the menu disappears immediately when I press the mouse button. In chrome, the menu stays open when I press the mouse button. The menu item is only selected/clicked when I release the mouse button. I am unsure if the menu is closed on mouse up or only when the new page is loaded.

@DionTimmermann DionTimmermann added the Type:Bug Something isn't working label Oct 4, 2024
@pascalwengerter
Copy link
Contributor

If only every issue opened was this detailed 🙏🏽 ☺️

@kulmann
Copy link
Member

kulmann commented Oct 4, 2024

If only every issue opened was this detailed 🙏🏽 ☺️

I second that 😍 Thank you for the detailed bug report!

Also, I can confirm the bug in Safari 17.5. And your assumption @DionTimmermann seems to be correct, when I comment out the hide function body on the dropdown the app switcher works as expected in Safari (without closing)... need to investigate further.

@kulmann kulmann moved this from Qualification to Prio 2 in Infinite Scale Team Board Oct 4, 2024
@kulmann kulmann added the Priority:p2-high Escalation, on top of current planning, release blocker label Oct 4, 2024
@AlexAndBear AlexAndBear self-assigned this Oct 6, 2024
@AlexAndBear AlexAndBear moved this from Prio 2 to In progress in Infinite Scale Team Board Oct 6, 2024
@DionTimmermann
Copy link
Author

DionTimmermann commented Oct 6, 2024

Thank you for the quick reaction!

I was about to open a new bug report, but based on the wording in the code, the bugfix above should also solve the following issue:

The "My Account" menu at top right also does not work in Safari. When I click on the "My Account" Menu it opens up, but clicking on e.g. "Preferences" just closes the menu. It seems to be exactly same behaviour as with the "Application Switcher".

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Oct 6, 2024

Thank you for the quick reaction!

I was about to open a new bug report, but based on the wording in the code, the bugfix above should also solve the following issue:

The "My Account" menu at top right also does not work in Safari. When I click on the "My Account" Menu it opens up, but clicking on e.g. "Preferences" just closes the menu. It seems to be exactly same behaviour as with the "Application Switcher".

Thank you, we identified the issue. The (not yet merged) bugfix should solve all the issues with drop menus.

@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants