Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails are displayed in some places and in some places not #11207

Closed
ScharfViktor opened this issue Jul 17, 2024 · 5 comments · Fixed by #11209
Closed

Thumbnails are displayed in some places and in some places not #11207

ScharfViktor opened this issue Jul 17, 2024 · 5 comments · Fixed by #11209
Assignees
Labels
Type:Bug Something isn't working

Comments

@ScharfViktor
Copy link
Contributor

web 6.1.0+0b8559f91
ocis 9.1.0

Thumbnails are not displayed on the:

  • /files/spaces
  • /files/search pages

Thumbnails are displayed on the:

  • /files/shares

Steps:

  1. marie uploads png files to the personal or project space
  2. marie opens personal space https://host.docker.internal:9200/files/spaces/personal/marie?fileId=uuid

Actual: no thumbnails -> no GET preview request

  1. marie clicks by Details

Actual: can see file preview

  1. marie shares png file to admin
  2. admin goes to shares with me page

Expected: user can see thumbnails in the /files/spaces and files/search pages too.
not sure about search result
Screenshot 2024-07-17 at 15 59 01

Actual: admin can see thumbnails in the /files/shares page

Screen.Recording.2024-07-17.at.15.44.57.mov
@ScharfViktor ScharfViktor added the Type:Bug Something isn't working label Jul 17, 2024
@AlexAndBear
Copy link
Contributor

@ScharfViktor it behaves complete different for me, could you check the config.json in the network tab and look up the value for disablePreviews ?

@ScharfViktor
Copy link
Contributor Author

ScharfViktor commented Jul 17, 2024

@ScharfViktor it behaves complete different for me, could you check the config.json in the network tab and look up the value for disablePreviews ?

I found it https://github.com/owncloud/web/blob/master/dev/docker/ocis.web.config.json#L13

Then why preview is enabled on the "Share with Me" page?

I guess it behaves complete different for you because you use vite and here we enable preview: https://github.com/owncloud/web/blob/master/vite.config.ts#L81

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Jul 17, 2024

Yup it should not behave different between shared with me and personal space page (some vars are missing).
I would leave the ticket open, and try to make the behavior equal for all views. (assigning myself)

I wonder why we have the option to disable thumbnails in general @kulmann any idea?

const displayThumbnails = computed(() => configStore.options.disablePreviews)

Ooopsie :D should be negotiated I think

@AlexAndBear AlexAndBear self-assigned this Jul 17, 2024
@AlexAndBear
Copy link
Contributor

@ScharfViktor can you check if everything is working now as expected:
#11209

I am not on a computer rn

@AlexAndBear
Copy link
Contributor

Discussed with @kulmann we will remove all of this restriction and configuration stuff

@github-project-automation github-project-automation bot moved this from Qualification to Done in Infinite Scale Team Board Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants