Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Enable Fulltext Search by default #10534

Closed
13 tasks
tbsbdr opened this issue Feb 13, 2024 · 10 comments · Fixed by #10626
Closed
13 tasks

[web] Enable Fulltext Search by default #10534

tbsbdr opened this issue Feb 13, 2024 · 10 comments · Fixed by #10626
Assignees
Labels
Priority:p3-medium Normal priority Type:Story User Story Web-only Issue without backend dependecies

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Feb 13, 2024

Description

User Stories

  • As a user I want that the standard search searches in fulltext so that I get maximum searchresults.

Value

  • improve file search behaviour
  • consistent behaviour of search filters (all filter narrow down; currently "search only in content" extends the search results)

Acceptance Criteria

  • klick on 🔍 searches in content and title per default (if fulltext search is not available -> title only, like it already is now)
  • replace filter "search only in content" with "Title only" (if fulltext search is not available -> don't show the filter)
    • click on "Title only" narrows down search results for matches in the title only
  • tech cherry on top: don't escape quotes anymore. @fschade claims that search works without escaping the quotes.

Definition of ready

  • Everybody needs to understand the value written in the user story
  • Acceptance criteria have to be defined
  • All dependencies of the user story need to be identified
  • Feature should be seen from an end user perspective
  • Story has to be estimated
  • Story points need to be less than 20

Definition of done

  • Functional requirements
    • Functionality described in the user story works
    • Acceptance criteria are fulfilled
  • Quality
    • Code review happened
    • CI is green (that includes new and existing automated tests)
    • e2e tests are adjusted to new behaviour
    • Critical code received unit tests by the developer
  • Non-functional requirements
    • No sonar cloud issues
@tbsbdr tbsbdr added Type:Story User Story Priority:p3-medium Normal priority labels Feb 13, 2024
@AlexAndBear
Copy link
Contributor

AlexAndBear commented Feb 15, 2024

Not a fan. I'd rather search for content and title by default and omit the search in content filter completely

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Feb 15, 2024

Not a fan. I'd rather search for content and title by default and omit the search in content filter completely

Thats what I want too 👍
Plus: provide a "Title only" filter

@kulmann
Copy link
Member

kulmann commented Feb 15, 2024

That would need a change in the backend search behaviour. At the moment you can only decide if you want content-search or filename-search, never both at the same time.

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Feb 15, 2024

ok, thanks for the remark @kulmann. do you agree that the std search should be title+content ?

@kulmann
Copy link
Member

kulmann commented Feb 15, 2024

do you agree that the std search should be title+content ?

Yes, I do!

@micbar micbar transferred this issue from owncloud/web Mar 4, 2024
@micbar
Copy link
Contributor

micbar commented Mar 4, 2024

Please Clarify why this is a backend issue?

We support the KQL queries for searching for title OR content, what is missing?

@kulmann
Copy link
Member

kulmann commented Mar 4, 2024

Please Clarify why this is a backend issue?

We support the KQL queries for searching for title OR content, what is missing?

We need a) title AND content or b) title only
Afaik title AND content is not possible at the moment... if I'm wrong then there's nothing to do in ocis.

Argh, sorry, that was bogus... we just want to be able to search in title AND content at the same time, but it's sufficient if the search term is only present in title OR content. However, I thought that the current implementation only allows a search in either title or content but not combined.

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Mar 4, 2024

Create emptytext.txt and new.txt with some new text content
try to find by text

<oc:pattern>content:&quot;text&quot; OR name:&quot;*text*&quot;</oc:pattern> - 207 text.txt and new.txt in response

<oc:pattern>content:&quot;text&quot; AND name:&quot;*text*&quot;</oc:pattern> - 207 empty response.

a) title AND content

try to find by new using AND

<oc:pattern>content:&new;text&quot; AND name:&quot;*new*&quot;</oc:pattern> - 207 and only new.txt in response

@kulmann
Copy link
Member

kulmann commented Mar 4, 2024

Updated my comment, title AND content was my fault, not what I intended to say, sorry.

@kulmann
Copy link
Member

kulmann commented Mar 4, 2024

Ok, thanks @ScharfViktor - works like we need it. Transferring back to web.

@kulmann kulmann transferred this issue from owncloud/ocis Mar 4, 2024
@tbsbdr tbsbdr added the Web-only Issue without backend dependecies label Mar 4, 2024
@fschade fschade removed their assignment Mar 6, 2024
@fschade fschade changed the title Enable Fulltext Search by default [web] Enable Fulltext Search by default Mar 7, 2024
@AlexAndBear AlexAndBear self-assigned this Mar 11, 2024
@AlexAndBear AlexAndBear moved this from Backlog to In progress in Infinite Scale Team Board Mar 12, 2024
@AlexAndBear AlexAndBear assigned fschade and unassigned AlexAndBear Mar 13, 2024
@AlexAndBear AlexAndBear moved this from In progress to Backlog in Infinite Scale Team Board Mar 15, 2024
@AlexAndBear AlexAndBear assigned JammingBen and unassigned fschade Mar 15, 2024
@JammingBen JammingBen moved this from Backlog to In progress in Infinite Scale Team Board Mar 18, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Story User Story Web-only Issue without backend dependecies
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants