Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all the archive files have appropriate icons #10031

Closed
2403905 opened this issue Nov 21, 2023 · 2 comments · Fixed by #10059
Closed

Not all the archive files have appropriate icons #10031

2403905 opened this issue Nov 21, 2023 · 2 comments · Fixed by #10059
Assignees
Labels
Type:Bug Something isn't working

Comments

@2403905
Copy link
Contributor

2403905 commented Nov 21, 2023

Describe the bug

The files tar.gz and tar.bz2 don't have the appropriate icon in a UI

Steps to reproduce

  1. Create the archive files tar cfvj archive.tar.bz2 file.txt, tar cfzv archive.tar.gz file.txt
  2. Upload the files to the personal space

Expected behavior

The archive files have appropriate icons

Actual behavior

The archive files have the default icons

Setup

Please describe how you started the server and provide a list of relevant environment variables or configuration files.

OCIS_XXX=somevalue
OCIS_YYY=somevalue
PROXY_XXX=somevalue

Additional context

Add any other context about the problem here.
Screenshot 2023-11-21-1

@2403905 2403905 added the Type:Bug Something isn't working label Nov 21, 2023
@2403905 2403905 changed the title No all the archive files have appropriate icons Not all the archive files have appropriate icons Nov 21, 2023
@pascalwengerter
Copy link
Contributor

Happy to work on this, what's the definition of done? CC @tbsbdr https://en.wikipedia.org/wiki/List_of_archive_formats lists quite a lot of possible endings, some of which may be pretty exotic? I could all of them (like in #9966) or a reduced list

@pascalwengerter pascalwengerter self-assigned this Nov 22, 2023
@kulmann
Copy link
Member

kulmann commented Nov 22, 2023

Happy to work on this, what's the definition of done? CC @tbsbdr https://en.wikipedia.org/wiki/List_of_archive_formats lists quite a lot of possible endings, some of which may be pretty exotic? I could all of them (like in #9966) or a reduced list

Please only add the two from the issue description, .tar.gz and .tar.bz2. If we don't have .7z then please add that as well. I still consider these 3 mainstream formats. Should be good for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants