From c1a35b8252995f341cf910edb0093e178f388924 Mon Sep 17 00:00:00 2001
From: Benedikt Kulmann <benedikt@kulmann.biz>
Date: Thu, 27 Jun 2024 14:41:23 +0200
Subject: [PATCH] fix: fetch activities on resource update

---
 .../components/SideBar/ActivitiesPanel.vue    | 46 +++++++++++++++----
 1 file changed, 37 insertions(+), 9 deletions(-)

diff --git a/packages/web-app-files/src/components/SideBar/ActivitiesPanel.vue b/packages/web-app-files/src/components/SideBar/ActivitiesPanel.vue
index 3e7945a392a..7c4f5c38c3e 100644
--- a/packages/web-app-files/src/components/SideBar/ActivitiesPanel.vue
+++ b/packages/web-app-files/src/components/SideBar/ActivitiesPanel.vue
@@ -20,7 +20,17 @@
 </template>
 
 <script lang="ts">
-import { computed, defineComponent, inject, onBeforeUnmount, onMounted, Ref, ref, unref } from 'vue'
+import {
+  computed,
+  defineComponent,
+  inject,
+  onBeforeUnmount,
+  onMounted,
+  Ref,
+  ref,
+  unref,
+  watch
+} from 'vue'
 import { useGettext } from 'vue3-gettext'
 import {
   AppLoadingSpinner,
@@ -40,7 +50,7 @@ export default defineComponent({
   setup() {
     const rootElement = ref<HTMLElement>()
     const { $gettext, current: currentLanguage } = useGettext()
-    const { graphAuthenticated } = useClientService()
+    const clientService = useClientService()
     const resource = inject<Ref<Resource>>('resource')
     const activities = ref<Activity[]>([])
     const activitiesLimit = 200
@@ -52,16 +62,17 @@ export default defineComponent({
     })
 
     const loadActivitiesTask = useTask(function* (signal) {
+      console.log('loading activities')
       const {
         data: { value: activitiesResponse }
       } = yield* call(
-        graphAuthenticated.activities.listActivities(
+        clientService.graphAuthenticated.activities.listActivities(
           `itemid:${unref(resource).id} AND limit:${activitiesLimit} AND sort:desc`
         )
       )
 
       activities.value = activitiesResponse
-    })
+    }).restartable()
 
     const isLoading = computed(() => {
       return loadActivitiesTask.isRunning || !loadActivitiesTask.last
@@ -70,10 +81,7 @@ export default defineComponent({
     const getHtmlFromActivity = (activity: Activity) => {
       let message = activity.template.message
       for (const [key, value] of Object.entries(activity.template.variables)) {
-        message = message.replace(
-          `{${key}}`,
-          `<strong>${value.displayName || value.name}</strong>`
-        )
+        message = message.replace(`{${key}}`, `<strong>${value.displayName || value.name}</strong>`)
       }
       return message
     }
@@ -83,9 +91,29 @@ export default defineComponent({
       return formatDateFromDateTime(dateTime, currentLanguage)
     }
 
+    const isVisible = ref(false)
+    watch(
+      [resource, isVisible],
+      () => {
+        if (!unref(isVisible)) {
+          return
+        }
+        loadActivitiesTask.perform()
+      },
+      {
+        immediate: true,
+        deep: true
+      }
+    )
+
     onMounted(() => {
       visibilityObserver.observe(unref(rootElement), {
-        onEnter: () => loadActivitiesTask.perform()
+        onEnter: () => {
+          isVisible.value = true
+        },
+        onExit: () => {
+          isVisible.value = false
+        }
       })
     })