Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "empty folder" indicator #1910

Closed
PVince81 opened this issue Sep 5, 2019 · 8 comments · Fixed by #2975
Closed

Missing "empty folder" indicator #1910

PVince81 opened this issue Sep 5, 2019 · 8 comments · Fixed by #2975
Assignees
Labels
Estimation:L(5) feature:files Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working Type:Design

Comments

@PVince81
Copy link
Contributor

PVince81 commented Sep 5, 2019

Steps to reproduce

  1. Create a new folder
  2. Navigate into it

Expected behaviour

See a message like "This folder is empty" or a nice graphic that tells me I should upload something. (like in the old UI)

Actual behaviour

File list is empty. The header is there. It looks broken.

Version

Phoenix 2f7b3d7

@PVince81 PVince81 added Type:Bug Something isn't working Type:Design labels Sep 5, 2019
@PVince81 PVince81 self-assigned this Sep 5, 2019
@PVince81 PVince81 mentioned this issue Sep 5, 2019
11 tasks
@PVince81
Copy link
Contributor Author

PVince81 commented Sep 5, 2019

PR here: #1911

@PVince81 PVince81 added this to the Milestone 1: Phoenix for users milestone Sep 24, 2019
@PVince81 PVince81 added Priority:p2-high Escalation, on top of current planning, release blocker feature:files labels Sep 24, 2019
@PVince81
Copy link
Contributor Author

  • when search has no results also need specific message ?
  • should we hide the bulk actions ? should we hide the filter box ? etc...

@wuenschedesign

@PVince81
Copy link
Contributor Author

  • what to do with "used space" indicator ?

@marcus-herrmann
Copy link
Contributor

when search has no results also need specific message ?

Definetly.

should we hide the bulk actions ? should we hide the filter box ? etc...

I understand the intention, but this would lead to a restless UI of some sort. Possibly disable it instead.

what to do with "used space" indicator ?

It seems that this got resolved already. I got no size information about its contents when visiting an empty folder. The "Used space" indicator could be advanced by adding some information that is referring to the whole owncloud installation, though.

@wuenschedesign
Copy link

wuenschedesign commented Dec 4, 2019

First draft, how an empty folder page could look like:

I would keep the action buttons on the top right NEW and the FILTER (disabled), so that user always see where to find them, even when the folder has got items inside.

Note: the image graphics like in this proposal should be designed in an overall style including print products and therefore being a part of a brand identity.

List-View-Closed-Empty

List-View-Closed-Empty-02

@wuenschedesign
Copy link

How an empty folder could look like in the sidebar:

Draft with Call-to-Action »Upload Files« Draft without Call-to-Action
Sidebar-Empty-Folder-01 Sidebar-Empty-Folder-02

@PVince81 PVince81 mentioned this issue Feb 5, 2020
12 tasks
@PVince81
Copy link
Contributor Author

PVince81 commented Feb 5, 2020

New PR here: #2975

@PVince81
Copy link
Contributor Author

PVince81 commented Feb 5, 2020

note: the most complex issue related to hidden files became obsolete due to #2971 and the fact that we now always show the hidden entries (dot files)

however, once we bring back this option we'll need to reconsider the message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimation:L(5) feature:files Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working Type:Design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants