OCM. sharing issues

[ScharfViktor]

precondition:

• run two ocis instances ocis-server and federation-ocis-server see here https://owncloud.dev/ocis/development/testing/#running-test-suite-with-federated-sharing-ocm

test 1. users shares folder to federation users after receiver accepted invitation

TEST_SERVER_URL="https://ocis-server:9200" TEST_SERVER_FED_URL="https://federation-ocis-server:10200" BEHAT_FEATURE="tests/acceptance/features/apiOcm/share.feature:12" make test-acceptance-api
Steps:

Given using server "LOCAL"
   And "Alice" has generated invitation
   And using server "REMOTE"
   And "Brian" has accepted invitation
   And using server "LOCAL"
   And user "Alice" has created folder "folderToShare"
   When user "Alice" sends the following resource share invitation using the Graph API:
     | resource        | folderToShare |
     | space           | Personal      |
     | sharee          | Brian         |
     | shareType       | user          |
     | permissionsRole | Viewer        |
   Then the HTTP status code should be "200"
   When using server "REMOTE"
   And user "Brian" lists the shares shared with him using the Graph API
   Then the HTTP status code should be "200"
   And the JSON data of the response should match

Actual: no share for Brian. Alice refresh page-> share disappears

Uploading Screen Recording 2024-01-30 at 12.36.58.mov…

test 2. users shares folder to federation users after accepting invitation

TEST_SERVER_URL="https://ocis-server:9200" TEST_SERVER_FED_URL="https://federation-ocis-server:10200" BEHAT_FEATURE="tests/acceptance/features/apiOcm/share.feature:90" make test-acceptance-api
Steps:

Given using server "LOCAL"
    And "Alice" has generated invitation
    And using server "REMOTE"
    And "Brian" has accepted invitation
    And user "Brian" has created folder "folderToShare"
    When user "Brian" sends the following resource share invitation using the Graph API:
      | resource        | folderToShare |
      | space           | Personal      |
      | sharee          | Alice         |
      | shareType       | user          |
      | permissionsRole | Viewer        |
    Then the HTTP status code should be "200"
    When using server "LOCAL"
    And user "Alice" lists the shares shared with her using the Graph API
    Then the HTTP status code should be "200"
    And the JSON data of the response should match

Actual:

1. federated share is not accepted by default
2. no displayName of the user sharer
3. how is the web supposed to determine that it's a federated resource? there's no type in the response.
4. no eTag in the response - no clue maybe we don't need to.

CC @butonic @aduffeck

[micbar]

Needs #9554

[ScharfViktor]

checked again:

1. users shares folder to federation users after receiver accepted invitation - works fine

but sharer cannot change share and delete share (existing bug #9926)

2024-09-09T16:26:50+02:00 INF access-log bytes=212 duration=74.548042 line=/Users/scharfviktor/Work/ocis/services/proxy/pkg/middleware/accesslog.go:34 method=PATCH path=/graph/v1beta1/drives/storage-users-1$dd5c9609-c0d8-4e97-a870-87d39f72573b/items/storage-users-1$dd5c9609-c0d8-4e97-a870-87d39f72573b!e511d04e-eb8a-43a0-96e4-93f37f5e9175/permissions/f347127e-5569-49c8-94b5-e5d7ddb0dd85 proto=HTTP/1.1 remote-addr=127.0.0.1:53217 request-id=f8160600-ab78-4311-88a3-cd0230f2e668 service=proxy status=404 traceid=bae32e0b0eced049db31cadc2246b8e8

2. users shares folder to federation users after accepting invitation - doesn't work

user can share but after refreshing -> share disappears

123.mov

[ScharfViktor]

retest again after getting this fix cs3org/reva#4840

Steps:

• tom(ocis-server:9200) generate invitation
• alice(federation-ocis-server:10200) accepts invitation
• alice(federation-ocis-server:10200) creates folder and shares to tom(ocis-server:9200) - works ✅️. after refresh page - works ✅️
• tom(ocis-server:9200) checks share with me - share exist ✅️. filter by shareType=external works ✅️
• tom(ocis-server:9200) creates folder and shares to alice(federation-ocis-server:10200) - works ✅️. after refresh page - works ✅️
• alice(federation-ocis-server:10200) checks share with me - share doesn't exist - Fail

[micbar]

@ScharfViktor The last step alice(federation-ocis-server:10200) checks share with me - share doesn't exist - Fail

should work now.

[ScharfViktor]

should work now.

yes I know, I want to change test today

[ScharfViktor]

Checked and closed as fixed