Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity. "was downloaded via public link" activity looks as spam #10293

Closed
ScharfViktor opened this issue Oct 14, 2024 · 8 comments · Fixed by #10368
Closed

Activity. "was downloaded via public link" activity looks as spam #10293

ScharfViktor opened this issue Oct 14, 2024 · 8 comments · Fixed by #10368
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug

Comments

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Oct 14, 2024

ocis 6.5.0
web. 10.3.0

related: #10295

Steps:

  • admin creates space (or folder) and uploads inside 10 .png and .txt files
  • admin creates public link to space/folder
  • public opens link -> makes refresh page twice or more
  • admin opens activity

Actual: hundreds of activities that public downloads file
Screenshot 2024-10-14 at 12 26 40

@ScharfViktor ScharfViktor added Type:Bug Priority:p2-high Escalation, on top of current planning, release blocker labels Oct 14, 2024
@ScharfViktor ScharfViktor moved this from Qualification to Prio 2 in Infinite Scale Team Board Oct 14, 2024
@micbar micbar added Priority:p3-medium Normal priority and removed Priority:p2-high Escalation, on top of current planning, release blocker labels Oct 16, 2024
@micbar micbar moved this from Prio 2 to Prio 3 or less in Infinite Scale Team Board Oct 16, 2024
@micbar micbar added Priority:p2-high Escalation, on top of current planning, release blocker and removed Priority:p3-medium Normal priority labels Oct 16, 2024
@micbar micbar moved this from Prio 3 or less to Prio 2 in Infinite Scale Team Board Oct 16, 2024
@dragotin
Copy link
Contributor

dragotin commented Oct 16, 2024

If we could destinguish a notification type and the affected resource, the clients could "condens" the view, ie by displaying "file foobar.png was downloaded 15 times".

According to @kulmann the activity identifier is missing in the activity data. Please add that @micbar. After that, @kulmann please build a more condensed view.

@ScharfViktor
Copy link
Contributor Author

the problem here is that activity generates for GET preview and HEAD preview request

  • admin adds 5 .png files to folder and creates public link to folder
  • public opens link (admin gets 5 activity for HEAD preview request, and 5 activities for GET preview request)
  • public opens file detail (+1 activity again)
  • public opens one .png file in the image preview (+5 activity again)
  • public refresh page (+10 activities again)

Total: 26 activities that file.png was downloaded via public link WylawZkpQWBVlpe.
Public hasn't downloaded the file once.

@kobergj
Copy link
Collaborator

kobergj commented Oct 16, 2024

Public hasn't downloaded the file once.

This isn't correct. When you open a public link (or refresh it) the file WILL be downloaded from the webclient. You don't have the effect when opening a folder.

"file foobar.png was downloaded 15 times".

This is probably the best option. Not sure if aggregating frontend or backend side is better. Probably both has its (dis-) advantages.

@ScharfViktor
Copy link
Contributor Author

This isn't correct. When you open a public link (or refresh it) the file WILL be downloaded from the webclient. You don't have the effect when opening a folder.

that is not obvious to the user.
IMHO was downloaded in user context that is pressing the download button for the resource and getting file in file system?

@kobergj
Copy link
Collaborator

kobergj commented Oct 16, 2024

IMHO was downloaded in user context that is pressing the download button for the resource and getting file in file system?

I agree. But the server only sees the request to download the file, not the user pressing the download button. This is only happening on the client side.

@butonic
Copy link
Member

butonic commented Oct 21, 2024

Hm when I share an image with a public link and then open the link in a private window I can see an actual GET request to the full image, but I had to search the UI for the actual download action. So in theory we can differentiate thumbnail and actual download requests.

@micbar
Copy link
Contributor

micbar commented Oct 21, 2024

Decision

  • Disable it if the fix exceeds the time slot

@2403905 2403905 self-assigned this Oct 22, 2024
@saw-jan
Copy link
Member

saw-jan commented Oct 23, 2024

Public hasn't downloaded the file once.

This isn't correct. When you open a public link (or refresh it) the file WILL be downloaded from the webclient. You don't have the effect when opening a folder.

We have an open issue for this behavior: #10231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants