Version 14 Queries #980
Replies: 2 comments 1 reply
-
We were all added at the same time, the only one who could answer is @MortenDHansen
I don't think it makes much difference, what you feel more comfortable with.
If there is no feature that is lost, I don't see a problem either, but it seems to me that if something was being added, it would be a matter of adding it again if so |
Beta Was this translation helpful? Give feedback.
-
Lumen support should already be removed in V14 |
Beta Was this translation helpful? Give feedback.
-
@erikn69 @parallels999 (sorry I couldn't find you both on discord so I thought this was the easiest option)
I've spent a bit of time on the v14-dev branch and phpstan can get to level 8 although I haven't tested this in a real project so might need some further tweaks.
I am a little confused about php-cs-fixer, I've never been able to configure it as I expect so normally I use squizlabs/php_codesniffer or easy-coding-standard. The main difference is the space around the
.
operator which php-cs-fixer does not enforce but the other two do so I'd like to switch to something more predictable if that is okay with you.Most confusingly I don't understand the reasoning behind moving almost all of src/Auditable.php into traits, making it much more difficult to follow the git history and also presenting a few challenges to phpstan as there are a few gaps in the interfaces. Do you know any of the reasoning behind it or should it go back into the one file? The separation also makes merging the master branch next to impossible and it would probably be easier to start again if it is to remain.
It would be good to get this wrapped up well before Laravel 12 so let me know what you think (or kick me on discord where I'm at the same username).
Beta Was this translation helpful? Give feedback.
All reactions