fix: add final flag on step condition #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deathiop
force-pushed
the
condition-final
branch
from
71dc5d0 to
1b9c084
Compare
rbeuque74
reviewed
Aug 25, 2023
Signed-off-by: Adrien Barreau <[email protected]>
deathiop
force-pushed
the
condition-final
branch
from
1b9c084 to
2271d13
Compare
|
Fixes #429 |
|
Fix #429 |
rbeuque74
approved these changes
Aug 29, 2023
|
@rclsilver Assigned it to you, seems good to me, if you are also OK with that, let's proceed to merge :) |
|
LGTM, merging |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
every condition is evaluated, whatever its output: the last one that matched wins
What is the new behavior (if this is a feature change)?
a step condition can now have
finalflag that prevent the execution of the next conditionsDoes this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no, the new flag on the conditions is optional and defaults on the current behavior (
falseby default)Other information: