-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: repair lint setup and run it in CI #15720
base: main
Are you sure you want to change the base?
Conversation
I think we're going to need to be very specific of what files have which linter rules apply. We necessarily do weird things in various tests. Things like And I don't think spending the time fixing made-up linter errors is higher priority than improving the Node.js passing test % |
@Jarred-Sumner I've greatly narrowed the scope of files subject to linting. You'll find the full list in the |
What does this PR do?
eslint
withoxlint
, which was not configured correctly. Before this PR,bun lint
simply crashed.oxlint
to only look for a set of strictly incorrect codebun lint
will display warnings locally, this job will not.How did you verify your code works?
Build + test locally