fix(node/readline): hang when closing on STDIN

[DonIsaac]

What does this PR do?

Fixes #15344

Calling close on a readline interface (either sync or from readline/promises) was not closing the underlying input. This was causing stdin to re-open, as unpause() was being called between emit("pause") and emit("close")

I'm not quite sure what was causing the segfault, but this fixes that too.

How did you verify your code works?

I've added test cases.

[robobun]

❌ Your commit faab0ab has 12 failures in #7529:

test/regression/issue/09041.test.ts - 1 failing on 🐧 3.20 x64-baseline

test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64

test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline

test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64

test/js/third_party/socket.io/socket.io-connection-state-recovery.test.ts - 4 failing on 🐧 22.04 aarch64

test/cli/hot/hot.test.ts - timeout on 🐧 24.04 x64-baseline

test/cli/hot/hot.test.ts - timeout on 🐧 24.04 x64

test/cli/hot/hot.test.ts - timeout on 🐧 3.20 x64-baseline

test/cli/hot/hot.test.ts - timeout on 🐧 3.20 x64

test/js/third_party/grpc-js/test-outlier-detection.test.ts - 1 failing on 🐧 22.04 aarch64

test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 24.04 x64

test/js/deno/performance/performance.test.ts - 1 failing on 🐧 24.04 x64-baseline

test/js/node/http/node-http.test.ts - 1 failing on 🐧 24.04 aarch64

test/js/node/http/node-http.test.ts - 1 failing on 🐧 22.04 aarch64

test/js/third_party/pino/pino.test.js - incorrect alignment on 🪟 2019 x64

test/js/third_party/pino/pino.test.js - segmentation fault at address 0x28dff22b940 on 🪟 2019 x64-baseline

test/js/third_party/pino/pino.test.js - segmentation fault at address 0x1bf4994f940 on 🪟 2022 x64-baseline

test/js/bun/spawn/spawn-signal.test.ts - 2 failing on 🪟 2025 x64

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🪟 2022 x64-baseline

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🪟 2025 x64-baseline

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🪟 2019 x64

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🪟 2019 x64-baseline

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🪟 2022 x64

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🪟 2025 x64

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🍎 13 aarch64

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🍎 14 aarch64

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 11 aarch64

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 24.04 aarch64

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 22.04 aarch64

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 12 aarch64

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 20.04 aarch64

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 24.04 x64-baseline

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 22.04 x64-baseline

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 12 x64-baseline

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 11 x64-baseline

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 20.04 x64-baseline

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 24.04 x64

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 22.04 x64

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 12 x64

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 11 x64

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 20.04 x64

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 3.20 aarch64

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 3.20 x64-baseline

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🐧 3.20 x64

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🍎 14 x64

test/js/third_party/prompts/prompts.test.ts - 1 failing on 🍎 13 x64

test/cli/run/require-cache.test.ts - 1 failing on 🪟 2022 x64-baseline

test/cli/run/require-cache.test.ts - 1 failing on 🪟 2019 x64-baseline

test/cli/run/require-cache.test.ts - 1 failing on 🪟 2019 x64

[paperdave]

damn

[Jarred-Sumner]

I'm confused why a JS-only change could/would fix a segfault

[Jarred-Sumner]

interesting

1 | })
2 |   let readRequest = @getByIdDirectPrivate(@getByIdDirectPrivate(stream, "reader"), "readRequests").shift();
                                                                                                      ^
TypeError: undefined is not an object (evaluating '@getByIdDirectPrivate(@getByIdDirectPrivate(stream, "reader"), "readRequests").shift')
      at handleResult (79:41)
      at promiseReactionJob (45:84)

[Jarred-Sumner]

Node's implementation doesn't call close on this.input, and most of readline is copypasta. I think this likely introduces bugs (which is supported by the test failure)

https://github.com/nodejs/node/blob/9c046ea8042c435d2cbecccbc1a1460630f59c3f/lib/internal/readline/interface.js#L516-L528