Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post details page missing the new {{tag}} styling #92

Closed
wants to merge 2 commits into from
Closed

Post details page missing the new {{tag}} styling #92

wants to merge 2 commits into from

Conversation

Ardakilic
Copy link
Contributor

Regarding the merged issue #79, the post details page was also missing the new {{tag}} helper methods. I did a quick test and this runs smoothly, so I did a fork to ease the process.

@andyleejordan
Copy link

@Ardakilic Pull request #90 implements the {{tag}} helper methods, and should be merged over #79.

@Ardakilic
Copy link
Contributor Author

@andschwa I'm not sure whether @oswaldoacauan will merge this, or decide to use {{tag}} way, he merged this way over {{tag}}s, and just in case I forked this.

@andyleejordan
Copy link

I'm keeping my fork with {{tags}} as well; it's clean, has a separator, and seems to be the Ghost way of doing it.

@Ardakilic
Copy link
Contributor Author

@andschwa I personally would prefer your way, indeed. This fork is done just to hasten his job. If he decides to go #90 way he'll merge yours, else he'll merge this. Easy as that 😄

@oswaldoacauan
Copy link
Owner

Manually merged on 2ff121c.

@andyleejordan
Copy link

Why the hard way over the {{tags}} helper? Just curious.

@oswaldoacauan
Copy link
Owner

@andschwa I want to keep the meta-data working since its one of the primary Ghostium features. 😊

@andyleejordan
Copy link

From what I can tell, you could just wrap the helper in a div class="post-meta-item" and the li it creates will, by virtue of being nested in the div, be identifiable by the class (since it is not an id). At least that's true as far as I remember of CSS. So the metadata will remain intact. Is there something I'm missing?

@andyleejordan
Copy link

(Or span, which one is "softer"?)

@oswaldoacauan
Copy link
Owner

@andschwa Im not talking about the .post-meta-item class. Im talking about HTML structured data(aka richsnippets), using the {{tag}} helper we will lose the itemprop attribute losing the meta-data of articleSection and keywords.

Example of how Google parse a Ghostium post meta-data.

@andyleejordan
Copy link

Ahhh. Thanks for the clarification. I wonder if there's a way to generate that with the helper.

On May 25, 2014 9:58:58 PM PDT, Oswaldo Acauan [email protected] wrote:

@andschwa Im not talking about the .post-meta-item class. Im talking
about HTML structured data(aka richsnippets),
using the {{tag}} helper we will lose the itemprop attribute losing
the meta-data of articleSection and keywords.


Reply to this email directly or view it on GitHub:
#92 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants