Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OALD url #70

Open
Jimmy-Z opened this issue Jul 8, 2015 · 6 comments
Open

OALD url #70

Jimmy-Z opened this issue Jul 8, 2015 · 6 comments

Comments

@Jimmy-Z
Copy link

Jimmy-Z commented Jul 8, 2015

'http://www.oxfordlearnersdictionaries.com/search/english/?q='

would be better than:

'http://www.oxfordlearnersdictionaries.com/definition/english/'

for example:
'Japan' via 1st URL
vs
'Japan' via 2nd URL

@Jimmy-Z
Copy link
Author

Jimmy-Z commented Jul 8, 2015

and OAAD, I know you've said you'll probably not add any more English downloaders.

like Heimlich maneuver,

oaad.py:

# download pronunciations from Oxford Advanced Learner's Dictionary

from .oald import OaldDownloader

class OaadDownloader(OaldDownloader):
    def __init__(self):
        OaldDownloader.__init__(self)
        self.url = \
                'http://www.oxfordlearnersdictionaries.com/search/american_english/?q='
        self.extras['Source'] = u'Oxford Advanced American Dictionary'

@Jimmy-Z
Copy link
Author

Jimmy-Z commented Jul 8, 2015

you mentioned OAAD in this part of the manual, but actually only OALD is included.

@ospalh
Copy link
Owner

ospalh commented Jul 8, 2015

Well, OAAD, OALD, who can keep them apart.
I’ll think about this.
Btw, you get Heimlich maneuver from MW and Japan from lots of sites.

@Jimmy-Z
Copy link
Author

Jimmy-Z commented Jul 8, 2015

I know, I know...

@ospalh
Copy link
Owner

ospalh commented Jul 8, 2015

And the chances i’ll publish the changes are better when you make a pull request.
(But i guess i will not have OAAD and OALD activated by default, similar to American,British} Macmillan)
And please

  • put an encoding and license header in the new file. Copy-and-paste, add your own ©
  • Make sure it is (mostly) PEP8-conform. GIYF
  • And add a (short) docstring to the class.

@ospalh
Copy link
Owner

ospalh commented Jul 31, 2015

Btw, i am not doing anything for this.
If you want this in the main version, please make a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants