[SmartAccount] Get authenticator query #8142

iboss-ptk · 2024-04-25T09:16:48Z

What is the purpose of the change

Query for getting single authenticator + stargate whitelist

Testing and Verifying

Tested through integration spend limit contract

Summary by CodeRabbit

New Features
- Introduced a new feature to fetch specific authenticators for smart accounts, enhancing user capabilities in managing account securities.
Enhancements
- Expanded whitelisted queries to support new smart account functionalities, improving interaction security and compliance.
Bug Fixes
- Updated error message formatting in spend limit tests to include more precise time details, enhancing debugging accuracy.

coderabbitai · 2024-04-25T09:17:48Z

Walkthrough

The recent updates aim to enhance smart account functionalities within the Osmosis blockchain framework. A new RPC, GetAuthenticator, now allows fetching specific authenticator data for smart accounts. Whitelisting for secure access and a test suite update for better error message precision further refine the system.

Changes

Files	Change Summary
`proto/.../query.proto`, `x/smart-account/keeper/query.go`	Added `GetAuthenticator` RPC to fetch specific authenticator data.
`wasmbinding/stargate_whitelist.go`	Added whitelisting for `GetAuthenticator` and `GetAuthenticators` queries.
`x/smart-account/authenticator/spend_limits_test.go`	Updated error message formatting to include nanoseconds.

🐇✨🌟
In the land of code where the smart accounts play,
A new RPC sprang up, hip hip hooray!
Fetching authenticators, both near and far,
Under the watchful eyes of the blockchain star.
Oh, how the data dances, precise and free,
In the magical grove of the binary tree!
🌟✨🐇

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 49c0a7b and 478aed5.

Files selected for processing (1)

proto/osmosis/smartaccount/v1beta1/query.proto (2 hunks)

Files skipped from review as they are similar to previous changes (1)

proto/osmosis/smartaccount/v1beta1/query.proto

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

nicolaslara · 2024-04-25T11:10:37Z

x/smart-account/authenticator/spend_limits_test.go

@@ -281,7 +281,7 @@ func (s *SpendLimitAuthenticatorTest) TestSpendLimit() {
 	s.Require().Contains(
 		err.Error(),
 		fmt.Sprintf(
-			"Current time %d.%d not within time limit None - %s.%s: execute wasm contract failed",
+			"Current time %d.%09d not within time limit None - %s.%s: execute wasm contract failed",


wasn't this already merged? https://github.com/osmosis-labs/osmosis/pull/8120/files

yeah not sure why it's in here.

will revert the commit and let the merge figure out.

PaddyMc

Would you mind adding a CHANGELOG entry?

This reverts commit 0c7252b.

This reverts commit e71dc74.

This reverts commit 300d81c.

coderabbitai

Actionable comments posted: 0

Out of diff range and nitpick comments (5)

CHANGELOG.md (5)
Line range hint 340-340: Remove trailing punctuation in heading.
-## [v6.4.0].
+## [v6.4.0]
Line range hint 603-603: Replace bare URL with a markdown link.
- https://github.com/osmosis-labs/cosmos-sdk/pull/100
+ [sdk-#100](https://github.com/osmosis-labs/cosmos-sdk/pull/100)
Line range hint 661-661: Replace bare URL with a markdown link.
- https://github.com/osmosis-labs/iavl/pull/5
+ [iavl-5](https://github.com/osmosis-labs/iavl/pull/5)
Line range hint 1242-1242: Ensure there are no empty links in the document.

Please check and update the link at line 1242 to ensure it directs to a valid URL or resource.

Line range hint 1001-1001: Ensure heading levels increment by one level at a time.

Please adjust the heading levels in the document to ensure they follow a logical order, incrementing by one level at a time.

iboss-ptk · 2024-04-26T03:02:15Z

Would you mind adding a CHANGELOG entry?

Added

This reverts commit 54cdef7.

…nges"" This reverts commit fe4f535.

iboss-ptk requested review from nicolaslara and PaddyMc April 25, 2024 09:16

nicolaslara reviewed Apr 25, 2024

View reviewed changes

nicolaslara approved these changes Apr 25, 2024

View reviewed changes

PaddyMc closed this Apr 25, 2024

PaddyMc reopened this Apr 25, 2024

PaddyMc approved these changes Apr 25, 2024

View reviewed changes

PaddyMc reviewed Apr 25, 2024

View reviewed changes

iboss-ptk added 5 commits April 26, 2024 09:44

add get_authenticator query

ad4c4c8

stargate whitelist all current smartaccount queries

832f1bb

fix fail build

0b417b9

Revert "fix non-deterministic spend limit test"

300d81c

This reverts commit 0c7252b.

update changelog

e71dc74

iboss-ptk force-pushed the boss/get-authenticator branch from 6c7226b to e71dc74 Compare April 26, 2024 02:47

Revert "update changelog"

f7bf5fb

This reverts commit e71dc74.

iboss-ptk force-pushed the boss/get-authenticator branch from 0c6f34f to f7bf5fb Compare April 26, 2024 02:50

iboss-ptk added 2 commits April 26, 2024 09:51

Revert "Revert "fix non-deterministic spend limit test""

d1b0483

This reverts commit 300d81c.

update changelog without autoformat

49c0a7b

iboss-ptk force-pushed the boss/get-authenticator branch from 3ea2cf7 to 49c0a7b Compare April 26, 2024 02:55

iboss-ptk added the V:state/compatible/no_backport State machine compatible PR, depends on prior breaks label Apr 26, 2024

Generated protofile changes

54cdef7

coderabbitai bot reviewed Apr 26, 2024

View reviewed changes

iboss-ptk self-assigned this Apr 26, 2024

iboss-ptk added 3 commits April 26, 2024 10:54

(fix staled gh action report) Revert "Generated protofile changes"

fe4f535

This reverts commit 54cdef7.

Revert "(fix staled gh action report) Revert "Generated protofile cha…

e9adda3

…nges"" This reverts commit fe4f535.

fix wrong type

478aed5

PaddyMc merged commit bb3d2ed into main Apr 26, 2024
1 check passed

PaddyMc deleted the boss/get-authenticator branch April 26, 2024 09:18

github-actions bot mentioned this pull request May 1, 2024

Broken Links Detected #8183

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SmartAccount] Get authenticator query #8142

[SmartAccount] Get authenticator query #8142

iboss-ptk commented Apr 25, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 25, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

nicolaslara Apr 25, 2024

iboss-ptk Apr 26, 2024

iboss-ptk Apr 26, 2024

PaddyMc left a comment •

edited

Loading

coderabbitai bot left a comment

iboss-ptk commented Apr 26, 2024

[SmartAccount] Get authenticator query #8142

[SmartAccount] Get authenticator query #8142

Conversation

iboss-ptk commented Apr 25, 2024 • edited by coderabbitai bot Loading

What is the purpose of the change

Testing and Verifying

Summary by CodeRabbit

coderabbitai bot commented Apr 25, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

nicolaslara Apr 25, 2024

Choose a reason for hiding this comment

iboss-ptk Apr 26, 2024

Choose a reason for hiding this comment

iboss-ptk Apr 26, 2024

Choose a reason for hiding this comment

PaddyMc left a comment • edited Loading

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

iboss-ptk commented Apr 26, 2024

iboss-ptk commented Apr 25, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 25, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

PaddyMc left a comment •

edited

Loading