Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: app.toml file with literal string for osmosis-mempool.arbitrage-min-gas-fee gets broken on startup #8055

Closed
sigv opened this issue Apr 15, 2024 · 2 comments

Comments

@sigv
Copy link
Contributor

sigv commented Apr 15, 2024

What happened?

The default app.toml file is generated with double-quotes for strings. However, we have tooling that rewrites the TOML file. We have the strings as single-quote literal.

This presents an issue with mempool configuration in app.toml. We have configuration:

[osmosis-mempool]
arbitrage-min-gas-fee = '.005'

When we start running the chain, this is overwritten to:

[osmosis-mempool]
0.1
arbitrage-min-gas-fee = '.005'

As result, next time Osmosis is restarted, app.toml file cannot be parsed and we encounter a failure.

Osmosis Version

24.0.0

How to reproduce?

Replace all double-quotes with single-quotes for app.toml, and start Osmosis chain binary:

[osmosis-mempool]
arbitrage-min-gas-fee = '.005'
@sigv sigv changed the title [Bug]: app.toml file with literal strings gets broken on Osmosis startup [Bug]: app.toml file with literal strings gets broken on startup Apr 15, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Apr 15, 2024
@sigv sigv changed the title [Bug]: app.toml file with literal strings gets broken on startup [Bug]: app.toml file with literal string for osmosis-mempool.arbitrage-min-gas-fee gets broken on startup Apr 15, 2024
@sigv
Copy link
Contributor Author

sigv commented Apr 15, 2024

Mitigation is possible by applying --reject-config-defaults flag to binary.

@sigv
Copy link
Contributor Author

sigv commented Apr 24, 2024

Resolved via #8118.

@sigv sigv closed this as completed Apr 24, 2024
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to In Progress🏃 in Osmosis Chain Development Apr 24, 2024
@github-project-automation github-project-automation bot moved this from In Progress🏃 to Done ✅ in Osmosis Chain Development Apr 24, 2024
@PaddyMc PaddyMc closed this as completed Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants