Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: TokenFactory CLI --help for create-denom is outdated as it includes (cost osmo though!) #7942

Closed
MbBrainz opened this issue Apr 3, 2024 · 3 comments · Fixed by #8248

Comments

@MbBrainz
Copy link

MbBrainz commented Apr 3, 2024

What happened?

when running osmosid tx tokenfactory the help documentation shows (Costs osmo though!), while since may 2023 this is not the case anymore (PR with on chain proposal link).

This confused me as there was no way to add the fee to the transaction and so i set the --fees parameter to 100osmo, (which was the price for tokenfactory a while ago). This was (in hindsight) obviously stupid as its the gas fee and it cased me to have the transaction fail, but the gas fee still payed (basically leading me to spend 100Osmo on fee for nothing (see tx).

❯ osmosisd tx tokenfactory
tokenfactory transactions subcommands

Usage:
  osmosisd tx tokenfactory [command]

Available Commands:
  burn                Burn tokens from an address. Must have admin authority to do so.
  change-admin        Changes the admin address for a factory-created denom. Must have admin authority to do so.
  create-denom        create a new denom from an account. (Costs osmo though!)
  mint                Mint a denom to an address. Must have admin authority to do so.
  set-beforesend-hook Set a cosmwasm contract to be the beforesend hook for a factory-created denom. Must have admin authority to do so.

Osmosis Version

23.0.8

How to reproduce?

install daemon and run osmosisd tx tokenfactory

@deividaspetraitis
Copy link
Contributor

hey, please correct if I am wrong, as per my understanding by simply removing (Costs osmo though!) from the docs should solve the issue, is that right? As per proposal denom creation fee should be 0, unless something have changed since them. I would be more than happy to update docs. cc @PaddyMc

@MbBrainz
Copy link
Author

MbBrainz commented May 9, 2024

probably yes

@deividaspetraitis
Copy link
Contributor

Opened PR-8248. In case there is any additional work that should be reflected in PR, I am looking forward to discuss it and implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants