Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for 6.x branch to either remove or include pool cleanup #794

Closed
mattverse opened this issue Jan 27, 2022 · 4 comments
Closed

Fix test for 6.x branch to either remove or include pool cleanup #794

mattverse opened this issue Jan 27, 2022 · 4 comments
Labels
C:x/gamm Changes, features and bugs related to the gamm module. V6

Comments

@mattverse
Copy link
Member

Currently the 6.x branch test is broken: it's mainly because we're not including gamm generalization v6.x(which we decided not to include in v6.x), but also because pool cleanup(#652) is currently not included in v6.x.

Our take should be:

  • either remove pool_test.go where pool cleanup tests are included
  • or include pool cleanup in v6.x

depending on whether we want pool cleanup in 6.x or not.

@mattverse mattverse added C:x/gamm Changes, features and bugs related to the gamm module. V6 labels Jan 27, 2022
@ValarDragon
Copy link
Member

Aren't the tests broken due to the function rename? Couldn't we just find/replace all of the new function signatures with the old ones?

@mattverse
Copy link
Member Author

mattverse commented Jan 27, 2022

They are broken due to function rename but also,

they are also broken because 6.x includes pool clean up tests(https://github.com/osmosis-labs/osmosis/blob/v6.x/x/gamm/keeper/pool_test.go#L68), but not the actual logic and methods for pool cleanup

@ValarDragon
Copy link
Member

Ah I see, your right we should revert the pool cleanup change from the v6.x branch entirely!

@mattverse
Copy link
Member Author

Closing in favor of #799

Repository owner moved this from 🔍 Needs Review to ✅ Done in Osmosis Chain Development Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/gamm Changes, features and bugs related to the gamm module. V6
Projects
Archived in project
Development

No branches or pull requests

2 participants