Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate config and app toml override logic #7905

Closed
linear bot opened this issue Apr 1, 2024 · 1 comment · Fixed by #8118
Closed

Investigate config and app toml override logic #7905

linear bot opened this issue Apr 1, 2024 · 1 comment · Fixed by #8118

Comments

@linear
Copy link

linear bot commented Apr 1, 2024

Rationale

Chorus One validator as well as one other claim that some of the configs such as peer values are getting overwritten. https://discord.com/channels/798583171548840026/842550346865180682/1223060434056253514

This should not occur, there are only a handful of items that should get changed, and peers is not one of them

DoD

  • Create a README with values expected to be overwritten

  • Recreate the scenario, showing that other values such as peers do in fact get overwritten

  • Change logic so that the only values getting overwritten are the ones in the README to the expected values

Copy link
Member

czarcas7ic commented Apr 2, 2024

I am unable to replicate this, I am asking Mateusz from Chorus One to attempt to replicate it as he is the one that originally reported it. If he is unable to I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant