Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Make CL swaps only fetch uptime accumulators if there is a tick crossing #7536

Closed
ValarDragon opened this issue Feb 19, 2024 · 0 comments · Fixed by #7550
Closed
Assignees

Comments

@ValarDragon
Copy link
Member

ValarDragon commented Feb 19, 2024

Summary

CL does far too many unnecessary state reads and writes. There will be several issues along these lines.

One thing is that Uptime Accumulators are only needed if there is a tick crossing. We fetch them on every single swap, which is an extra 5 state reads -- a notable sync speed cost!

Lets make them only get fetched once, if there is a tick cross. (And on repeated tick crossings, not do multiple fetches).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant