-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for Mempool tx fee architecture #738
Labels
Comments
Closed
Closed
This was referenced Nov 1, 2023
Closed
This was referenced Nov 15, 2023
Closed
This was referenced Dec 1, 2023
Closed
This was referenced Dec 15, 2023
Closed
This was referenced Jan 1, 2024
Closed
This was referenced Jan 15, 2024
Closed
This was referenced Feb 1, 2024
Closed
This was referenced May 15, 2024
Closed
This was referenced Jun 1, 2024
This was referenced Jun 15, 2024
This was referenced Jul 1, 2024
This was referenced Jul 15, 2024
This was referenced Aug 1, 2024
This was referenced Aug 15, 2024
This was referenced Sep 1, 2024
This was referenced Sep 15, 2024
This was referenced Oct 1, 2024
This was referenced Nov 1, 2024
This was referenced Nov 15, 2024
This was referenced Dec 1, 2024
This was referenced Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems pretty clear that there is value in making it simple to alter how the mempool prioritizes and charges for various different types of transactions. The advantage of an app-specific chain is that it can even go one step further, and do this in the state machine. (E.g. Terra's Send fee tax)
In Osmosis, we have a second goal, that per the multi-asset txfees work that got voted in by governance.
I propose the following interface for making it easy to add more transaction fee filters. (Note that the CheckTX side will become obsolete for any threshold encrypted tx once those land)
MinGasPrice
for a tx will be the sum of MinGasPrice for each filter. (Filters can both add and subtract to this!)FlatFee
will similarly be the sum of all flat fees for every filter. its denominated inuosmo
We then take the
Name
field, and automatically propogate app.toml config entries for this.Then we make the MempoolFeeDecorator take in a slioce FeeDecoratorFilters, get the sum of MinGasPrice and FlatFee for a tx. (Can also add in the current mempool config for min gas)
Then it converts the fee token amount into uosmo equivalent as it already does, and ensure the provided fee is sufficient
The other nice thing is its easy for filters to evolve into state machine filters, with the check tx / deliver tx distinctions.
The text was updated successfully, but these errors were encountered: