Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PoolAsset and manage corresponding fields in Balancer Params #681

Closed
mattverse opened this issue Dec 21, 2021 · 1 comment
Closed
Labels
C:x/gamm Changes, features and bugs related to the gamm module. T:code-hygiene T:task ⚙️ A task belongs to a story

Comments

@mattverse
Copy link
Member

Implementing gamm module generalization for different pool-models, we should move poolAsset in pool.proto into balancerParams or balancerPool. Token and token weights should be managed within the balancerPool package for better generalization of the gamm module.

@mattverse mattverse added T:code-hygiene C:x/gamm Changes, features and bugs related to the gamm module. labels Dec 21, 2021
@mconcat
Copy link
Collaborator

mconcat commented Jan 13, 2022

We may need to move pool weights into the balancer pool model, but not the pool assets, for managing the assets on the keeper side. Ref #131

@ValarDragon ValarDragon added the T:task ⚙️ A task belongs to a story label Mar 2, 2022
Repository owner moved this from 🕒 Todo to ✅ Done in Osmosis Chain Development Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/gamm Changes, features and bugs related to the gamm module. T:code-hygiene T:task ⚙️ A task belongs to a story
Projects
Archived in project
Development

No branches or pull requests

3 participants