Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI does not catch conflicts in go.sum files #6538

Open
pysel opened this issue Sep 25, 2023 · 0 comments
Open

CI does not catch conflicts in go.sum files #6538

pysel opened this issue Sep 25, 2023 · 0 comments
Assignees
Labels
Help wanted T:bug 🐛 Something isn't working T:CI

Comments

@pysel
Copy link
Member

pysel commented Sep 25, 2023

Background

CI can pass even if there are conflicts in go.sum files (note: it won't pass if there is a conflict in go.mod file). It can lead to potential merge with conflicts to main. Example: #6492 (comment) (at the time of writing, the comment is not outdated and CI is green).

Suggested Design

CI should catch these merge conflicts and block merge before they are resolved

Acceptance Criteria

CI catches merge conflicts in go.sum files (would be also nice to make sure that every other file is also checked, what if go.sums are not the only files?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help wanted T:bug 🐛 Something isn't working T:CI
Projects
Status: Needs Triage 🔍
Development

Successfully merging a pull request may close this issue.

2 participants